From: Matthew Wilcox <willy@infradead.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, samba-technical@lists.samba.org,
Eric Biggers <ebiggers@kernel.org>
Subject: Re: Streams support in Linux
Date: Sun, 26 Aug 2018 13:30:40 -0700 [thread overview]
Message-ID: <20180826203039.GA30765@bombadil.infradead.org> (raw)
In-Reply-To: <20180825223615.GS6515@ZenIV.linux.org.uk>
On Sat, Aug 25, 2018 at 11:36:15PM +0100, Al Viro wrote:
> On Sat, Aug 25, 2018 at 01:57:16PM -0700, Matthew Wilcox wrote:
>
> > > > Right, but that code also assumes it's dealing with files.
> > >
> > > I'm looking forward to your analysis of all code related to dentry tree,
> > > with an eye towards the places where such asserts are quietly made...
> >
> > I really was hoping not to change the dentry tree at all.
>
> Umhm... Just what, pray tell, would be used to hold the stream name when
> you are creating/removing/renaming it? And why are we talking about the
> use of existing syscalls for that thing? In effect, you are multiplexing
> entirely new syscalls, with different pathname resolution, etc. upon the
> existing ones, using that new AT_... flag to select them.
>
> Better yet, you need some new objects to represent those things, since
> you don't want any informative dentries. And not fs-private ones, at
> that, since those new syscalls of yours would have to operate on them
> (after all, renaming something opened would probably be expected to
> have the opened descriptor to keep accessing the same object, wouldn't
> it?)
Let's look at it this way ... suppose we have an fcntl F_SETSTREAM.
And our API looks like:
fd = open("/a/b/c", O_RDWR);
fcntl(fd, F_SETSTREAM, "verity");
read(fd, ...);
>From a VFS point of view, we just change file->f_inode to point to a
different inode. We probably also have to change file->f_op. Do we
also need to change file->f_path.dentry?
next prev parent reply other threads:[~2018-08-27 0:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-25 13:51 Streams support in Linux Matthew Wilcox
2018-08-25 14:47 ` Al Viro
2018-08-25 15:51 ` Matthew Wilcox
2018-08-25 18:00 ` Al Viro
2018-08-25 20:57 ` Matthew Wilcox
2018-08-25 22:36 ` Al Viro
2018-08-26 1:03 ` Steve French
2018-08-27 17:05 ` Jeremy Allison
2018-08-27 17:41 ` Jeremy Allison
2018-08-27 18:21 ` Matthew Wilcox
2018-08-27 18:45 ` Al Viro
2018-08-27 19:06 ` Jeremy Allison
2018-08-28 0:45 ` Theodore Y. Ts'o
2018-08-28 1:07 ` Steve French
2018-08-28 18:12 ` Jeremy Allison
2018-08-28 18:32 ` Steve French
2018-08-28 18:40 ` Jeremy Allison
2018-08-28 19:43 ` Steve French
2018-08-28 19:47 ` Jeremy Allison
2018-08-28 20:43 ` Steve French
2018-08-28 20:47 ` Jeremy Allison
2018-08-28 20:51 ` Steve French
2018-08-28 21:19 ` Stefan Metzmacher
2018-08-28 21:22 ` Jeremy Allison
2018-08-28 21:23 ` Steve French
2018-08-29 5:13 ` Ralph Böhme
2018-08-29 13:46 ` Tom Talpey
2018-08-29 13:54 ` Aurélien Aptel
2018-08-29 15:02 ` Tom Talpey
2018-08-29 16:00 ` Jeremy Allison
2018-08-29 15:59 ` Jeremy Allison
2018-08-29 18:52 ` Andreas Dilger
2018-08-26 20:30 ` Matthew Wilcox [this message]
2018-08-25 16:25 ` Theodore Y. Ts'o
2018-08-27 16:33 ` Jeremy Allison
2018-09-20 2:06 Shahbaz Youssefi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180826203039.GA30765@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=ebiggers@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).