From: Dan Carpenter <dan.carpenter@oracle.com> To: kbuild@01.org, Amir Goldstein <amir73il@gmail.com> Cc: linux-fsdevel@vger.kernel.org, Matthew Bobrowski <mbobrowski@mbobrowski.org>, Jan Kara <jack@suse.cz>, kbuild-all@01.org Subject: Re: [PATCH v5 10/17] fanotify: cache fsid in fsnotify_mark_connector Date: Mon, 14 Jan 2019 10:30:58 +0300 [thread overview] Message-ID: <20190114073058.GA4504@kadam> (raw) In-Reply-To: <20190110170444.30616-11-amir73il@gmail.com> Hi Amir, url: https://github.com/0day-ci/linux/commits/Amir-Goldstein/fanotify-add-support-for-more-event-types/20190111-090241 smatch warnings: fs/notify/fanotify/fanotify.c:194 fanotify_encode_fid() error: uninitialized symbol 'type'. fs/notify/fanotify/fanotify.c:194 fanotify_encode_fid() error: uninitialized symbol 'err'. # https://github.com/0day-ci/linux/commit/48b7a1af51abcb893917d986bc5ae5bae2d21ad6 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 48b7a1af51abcb893917d986bc5ae5bae2d21ad6 vim +/type +194 fs/notify/fanotify/fanotify.c 1c529063 Eric Paris 2009-12-17 154 688d9244 Amir Goldstein 2019-01-10 155 static int fanotify_encode_fid(struct fanotify_event *event, 48b7a1af Amir Goldstein 2019-01-10 156 const struct path *path, gfp_t gfp, 48b7a1af Amir Goldstein 2019-01-10 157 __kernel_fsid_t *fsid) 688d9244 Amir Goldstein 2019-01-10 158 { 688d9244 Amir Goldstein 2019-01-10 159 struct fanotify_fid *fid = &event->fid; 688d9244 Amir Goldstein 2019-01-10 160 int dwords, bytes = 0; 688d9244 Amir Goldstein 2019-01-10 161 int err, type; 688d9244 Amir Goldstein 2019-01-10 162 48b7a1af Amir Goldstein 2019-01-10 163 if (!fsid) 48b7a1af Amir Goldstein 2019-01-10 164 goto out_err; 48b7a1af Amir Goldstein 2019-01-10 165 688d9244 Amir Goldstein 2019-01-10 166 fid->ext_fh = NULL; 688d9244 Amir Goldstein 2019-01-10 167 dwords = 0; 688d9244 Amir Goldstein 2019-01-10 168 err = -ENOENT; 688d9244 Amir Goldstein 2019-01-10 169 type = exportfs_encode_fh(path->dentry, NULL, &dwords, 0); 688d9244 Amir Goldstein 2019-01-10 170 if (!dwords) 688d9244 Amir Goldstein 2019-01-10 171 goto out_err; 688d9244 Amir Goldstein 2019-01-10 172 688d9244 Amir Goldstein 2019-01-10 173 bytes = dwords << 2; 688d9244 Amir Goldstein 2019-01-10 174 if (bytes > FANOTIFY_INLINE_FH_LEN) { 688d9244 Amir Goldstein 2019-01-10 175 /* Treat failure to allocate fh as failure to allocate event */ 688d9244 Amir Goldstein 2019-01-10 176 err = -ENOMEM; 688d9244 Amir Goldstein 2019-01-10 177 fid->ext_fh = kmalloc(bytes, gfp); 688d9244 Amir Goldstein 2019-01-10 178 if (!fid->ext_fh) 688d9244 Amir Goldstein 2019-01-10 179 goto out_err; 688d9244 Amir Goldstein 2019-01-10 180 } 688d9244 Amir Goldstein 2019-01-10 181 688d9244 Amir Goldstein 2019-01-10 182 type = exportfs_encode_fh(path->dentry, fanotify_fid_fh(fid, bytes), 688d9244 Amir Goldstein 2019-01-10 183 &dwords, 0); 688d9244 Amir Goldstein 2019-01-10 184 err = -EINVAL; 688d9244 Amir Goldstein 2019-01-10 185 if (!type || type == FILEID_INVALID || bytes != dwords << 2) 688d9244 Amir Goldstein 2019-01-10 186 goto out_err; 688d9244 Amir Goldstein 2019-01-10 187 48b7a1af Amir Goldstein 2019-01-10 188 fid->fsid = *fsid; 688d9244 Amir Goldstein 2019-01-10 189 event->fh_len = bytes; 688d9244 Amir Goldstein 2019-01-10 190 688d9244 Amir Goldstein 2019-01-10 191 return type; 688d9244 Amir Goldstein 2019-01-10 192 688d9244 Amir Goldstein 2019-01-10 193 out_err: 688d9244 Amir Goldstein 2019-01-10 @194 pr_warn_ratelimited("fanotify: failed to encode fid (fsid=%x.%x, type=%d, bytes=%d, err=%i)\n", 48b7a1af Amir Goldstein 2019-01-10 195 fsid ? fsid->val[0] : 0, fsid ? fsid->val[1] : 0, 688d9244 Amir Goldstein 2019-01-10 196 type, bytes, err); 688d9244 Amir Goldstein 2019-01-10 197 kfree(fid->ext_fh); 688d9244 Amir Goldstein 2019-01-10 198 fid->ext_fh = NULL; 688d9244 Amir Goldstein 2019-01-10 199 event->fh_len = 0; 688d9244 Amir Goldstein 2019-01-10 200 688d9244 Amir Goldstein 2019-01-10 201 return FILEID_INVALID; 688d9244 Amir Goldstein 2019-01-10 202 } 688d9244 Amir Goldstein 2019-01-10 203
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: kbuild@01.org, Amir Goldstein <amir73il@gmail.com> Cc: kbuild-all@01.org, Jan Kara <jack@suse.cz>, Matthew Bobrowski <mbobrowski@mbobrowski.org>, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v5 10/17] fanotify: cache fsid in fsnotify_mark_connector Date: Mon, 14 Jan 2019 10:30:58 +0300 [thread overview] Message-ID: <20190114073058.GA4504@kadam> (raw) Message-ID: <20190114073058.785ChTs09dj3tEkXU3nUVncxYGjMVbxbIxONpcXOIW4@z> (raw) In-Reply-To: <20190110170444.30616-11-amir73il@gmail.com> Hi Amir, url: https://github.com/0day-ci/linux/commits/Amir-Goldstein/fanotify-add-support-for-more-event-types/20190111-090241 smatch warnings: fs/notify/fanotify/fanotify.c:194 fanotify_encode_fid() error: uninitialized symbol 'type'. fs/notify/fanotify/fanotify.c:194 fanotify_encode_fid() error: uninitialized symbol 'err'. # https://github.com/0day-ci/linux/commit/48b7a1af51abcb893917d986bc5ae5bae2d21ad6 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 48b7a1af51abcb893917d986bc5ae5bae2d21ad6 vim +/type +194 fs/notify/fanotify/fanotify.c 1c529063 Eric Paris 2009-12-17 154 688d9244 Amir Goldstein 2019-01-10 155 static int fanotify_encode_fid(struct fanotify_event *event, 48b7a1af Amir Goldstein 2019-01-10 156 const struct path *path, gfp_t gfp, 48b7a1af Amir Goldstein 2019-01-10 157 __kernel_fsid_t *fsid) 688d9244 Amir Goldstein 2019-01-10 158 { 688d9244 Amir Goldstein 2019-01-10 159 struct fanotify_fid *fid = &event->fid; 688d9244 Amir Goldstein 2019-01-10 160 int dwords, bytes = 0; 688d9244 Amir Goldstein 2019-01-10 161 int err, type; 688d9244 Amir Goldstein 2019-01-10 162 48b7a1af Amir Goldstein 2019-01-10 163 if (!fsid) 48b7a1af Amir Goldstein 2019-01-10 164 goto out_err; 48b7a1af Amir Goldstein 2019-01-10 165 688d9244 Amir Goldstein 2019-01-10 166 fid->ext_fh = NULL; 688d9244 Amir Goldstein 2019-01-10 167 dwords = 0; 688d9244 Amir Goldstein 2019-01-10 168 err = -ENOENT; 688d9244 Amir Goldstein 2019-01-10 169 type = exportfs_encode_fh(path->dentry, NULL, &dwords, 0); 688d9244 Amir Goldstein 2019-01-10 170 if (!dwords) 688d9244 Amir Goldstein 2019-01-10 171 goto out_err; 688d9244 Amir Goldstein 2019-01-10 172 688d9244 Amir Goldstein 2019-01-10 173 bytes = dwords << 2; 688d9244 Amir Goldstein 2019-01-10 174 if (bytes > FANOTIFY_INLINE_FH_LEN) { 688d9244 Amir Goldstein 2019-01-10 175 /* Treat failure to allocate fh as failure to allocate event */ 688d9244 Amir Goldstein 2019-01-10 176 err = -ENOMEM; 688d9244 Amir Goldstein 2019-01-10 177 fid->ext_fh = kmalloc(bytes, gfp); 688d9244 Amir Goldstein 2019-01-10 178 if (!fid->ext_fh) 688d9244 Amir Goldstein 2019-01-10 179 goto out_err; 688d9244 Amir Goldstein 2019-01-10 180 } 688d9244 Amir Goldstein 2019-01-10 181 688d9244 Amir Goldstein 2019-01-10 182 type = exportfs_encode_fh(path->dentry, fanotify_fid_fh(fid, bytes), 688d9244 Amir Goldstein 2019-01-10 183 &dwords, 0); 688d9244 Amir Goldstein 2019-01-10 184 err = -EINVAL; 688d9244 Amir Goldstein 2019-01-10 185 if (!type || type == FILEID_INVALID || bytes != dwords << 2) 688d9244 Amir Goldstein 2019-01-10 186 goto out_err; 688d9244 Amir Goldstein 2019-01-10 187 48b7a1af Amir Goldstein 2019-01-10 188 fid->fsid = *fsid; 688d9244 Amir Goldstein 2019-01-10 189 event->fh_len = bytes; 688d9244 Amir Goldstein 2019-01-10 190 688d9244 Amir Goldstein 2019-01-10 191 return type; 688d9244 Amir Goldstein 2019-01-10 192 688d9244 Amir Goldstein 2019-01-10 193 out_err: 688d9244 Amir Goldstein 2019-01-10 @194 pr_warn_ratelimited("fanotify: failed to encode fid (fsid=%x.%x, type=%d, bytes=%d, err=%i)\n", 48b7a1af Amir Goldstein 2019-01-10 195 fsid ? fsid->val[0] : 0, fsid ? fsid->val[1] : 0, 688d9244 Amir Goldstein 2019-01-10 196 type, bytes, err); 688d9244 Amir Goldstein 2019-01-10 197 kfree(fid->ext_fh); 688d9244 Amir Goldstein 2019-01-10 198 fid->ext_fh = NULL; 688d9244 Amir Goldstein 2019-01-10 199 event->fh_len = 0; 688d9244 Amir Goldstein 2019-01-10 200 688d9244 Amir Goldstein 2019-01-10 201 return FILEID_INVALID; 688d9244 Amir Goldstein 2019-01-10 202 } 688d9244 Amir Goldstein 2019-01-10 203 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2019-01-14 7:30 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-10 17:04 [PATCH v5 00/17] fanotify: add support for more event types Amir Goldstein 2019-01-10 17:04 ` [PATCH v5 01/17] fsnotify: annotate directory entry modification events Amir Goldstein 2019-02-06 14:14 ` Jan Kara 2019-01-10 17:04 ` [PATCH v5 02/17] fsnotify: remove dirent events from FS_EVENTS_POSS_ON_CHILD mask Amir Goldstein 2019-01-10 17:04 ` [PATCH v5 03/17] fsnotify: send all event types to super block marks Amir Goldstein 2019-01-10 17:04 ` [PATCH v5 04/17] fsnotify: move mask out of struct fsnotify_event Amir Goldstein 2019-01-10 17:04 ` [PATCH v5 05/17] fanotify: rename struct fanotify_{,perm_}event_info Amir Goldstein 2019-01-10 17:04 ` [PATCH v5 06/17] fanotify: open code fill_event_metadata() Amir Goldstein 2019-01-10 17:04 ` [PATCH v5 07/17] fanotify: encode file identifier for FAN_REPORT_FID Amir Goldstein 2019-01-11 8:10 ` kbuild test robot 2019-01-11 8:37 ` Amir Goldstein 2019-01-18 18:39 ` Paul Burton 2019-01-10 17:04 ` [PATCH v5 08/17] fanotify: copy event fid info to user Amir Goldstein 2019-02-06 17:41 ` Jan Kara 2019-01-10 17:04 ` [PATCH v5 09/17] fanotify: enable FAN_REPORT_FID init flag Amir Goldstein 2019-01-10 17:04 ` [PATCH v5 10/17] fanotify: cache fsid in fsnotify_mark_connector Amir Goldstein 2019-01-11 3:13 ` kbuild test robot 2019-01-14 7:30 ` Dan Carpenter [this message] 2019-01-14 7:30 ` Dan Carpenter 2019-01-14 9:17 ` Amir Goldstein 2019-02-07 14:48 ` Jan Kara 2019-02-07 16:31 ` Amir Goldstein 2019-02-08 10:15 ` Jan Kara 2019-01-10 17:04 ` [PATCH v5 11/17] vfs: add vfs_get_fsid() helper Amir Goldstein 2019-01-10 17:04 ` [PATCH v5 12/17] fanotify: use vfs_get_fsid() helper instead of vfs_statfs() Amir Goldstein 2019-01-10 17:04 ` [PATCH v5 13/17] fsnotify: report FS_ISDIR flag with MOVE_SELF and DELETE_SELF events Amir Goldstein 2019-02-07 14:57 ` Jan Kara 2019-01-10 17:04 ` [PATCH v5 14/17] fanotify: check FS_ISDIR flag instead of d_is_dir() Amir Goldstein 2019-01-10 17:04 ` [PATCH v5 15/17] fanotify: support events with data type FSNOTIFY_EVENT_INODE Amir Goldstein 2019-02-07 15:18 ` Jan Kara 2019-02-07 16:10 ` Amir Goldstein 2019-01-10 17:04 ` [PATCH v5 16/17] fanotify: add support for create/attrib/move/delete events Amir Goldstein 2019-01-10 17:04 ` [PATCH v5 17/17] fanotify: report FAN_ONDIR to listener with FAN_REPORT_FID Amir Goldstein 2019-02-07 16:26 ` [PATCH v5 00/17] fanotify: add support for more event types Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190114073058.GA4504@kadam \ --to=dan.carpenter@oracle.com \ --cc=amir73il@gmail.com \ --cc=jack@suse.cz \ --cc=kbuild-all@01.org \ --cc=kbuild@01.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=mbobrowski@mbobrowski.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).