From: Dan Williams <dan.j.williams@intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
Ross Zwisler <zwisler@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs/dax: Convert to use vmf_error()
Date: Mon, 14 Jan 2019 14:30:44 -0800 [thread overview]
Message-ID: <CAPcyv4hV0VQv9bMz9FWW_n734KiHY-HfLMHW_atG8Wqbnrf34A@mail.gmail.com> (raw)
Message-ID: <20190114223044.nA3Pe971oXWLUeK9i9hrXZTx2-S9QBiLK6_8YiwOUpo@z> (raw)
In-Reply-To: <20190114085839.GA13316@quack2.suse.cz>
On Mon, Jan 14, 2019 at 12:59 AM Jan Kara <jack@suse.cz> wrote:
>
> On Sat 05-01-19 00:54:11, Souptick Joarder wrote:
> > This code is converted to use vmf_error().
> >
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>
> Dan, you are merging DAX patches these days. So probably you should add
> yourself to 'FILESYSTEM DIRECT ACCESS (DAX)' in MAINTAINERs.
Sounds good, I'll merge this and get MAINTAINERs fixed up.
> Or I can start
> picking patches for fsdax to my tree if you are too busy but I think your
> tree is easier as there are less chances for conflicts etc.
>
> In either case this patch looks OK to me so feel free to add
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Honza
>
> > ---
> > fs/dax.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/fs/dax.c b/fs/dax.c
> > index 48132ec..ed39161 100644
> > --- a/fs/dax.c
> > +++ b/fs/dax.c
> > @@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
> > {
> > if (error == 0)
> > return VM_FAULT_NOPAGE;
> > - if (error == -ENOMEM)
> > - return VM_FAULT_OOM;
> > - return VM_FAULT_SIGBUS;
> > + return vmf_error(error);
> > }
> >
> > /*
> > --
> > 1.9.1
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
next prev parent reply other threads:[~2019-01-14 22:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 19:24 [PATCH] fs/dax: Convert to use vmf_error() Souptick Joarder
2019-01-14 4:28 ` Souptick Joarder
2019-01-14 4:28 ` Souptick Joarder
2019-01-14 8:58 ` Jan Kara
2019-01-14 8:58 ` Jan Kara
2019-01-14 22:30 ` Dan Williams [this message]
2019-01-14 22:30 ` Dan Williams
2019-02-05 2:33 ` Souptick Joarder
2019-02-05 2:42 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4hV0VQv9bMz9FWW_n734KiHY-HfLMHW_atG8Wqbnrf34A@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=jrdr.linux@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).