* [PATCH] vfs/xattr: strengthen error check to avoid unexpected result
@ 2020-06-17 1:08 Chengguang Xu
0 siblings, 0 replies; only message in thread
From: Chengguang Xu @ 2020-06-17 1:08 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, Chengguang Xu
The variable error is ssize_t, which is signed and will
cast to unsigned when comapre with variable size, so add
a check to avoid unexpected result in case of negative
value of error.
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/xattr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xattr.c b/fs/xattr.c
index e13265e65871..9d0f12682c86 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -356,7 +356,7 @@ vfs_listxattr(struct dentry *dentry, char *list, size_t size)
error = inode->i_op->listxattr(dentry, list, size);
} else {
error = security_inode_listsecurity(inode, list, size);
- if (size && error > size)
+ if (error >= 0 && size && error > size)
error = -ERANGE;
}
return error;
--
2.20.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-17 1:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-17 1:08 [PATCH] vfs/xattr: strengthen error check to avoid unexpected result Chengguang Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).