From: Vivek Goyal <vgoyal@redhat.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Casey Schaufler <casey@schaufler-ca.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, virtio-fs@redhat.com, dwalsh@redhat.com,
dgilbert@redhat.com, casey.schaufler@intel.com,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org,
miklos@szeredi.hu, gscrivan@redhat.com, jack@suse.cz,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v2 1/1] xattr: Allow user.* xattr on symlink and special files
Date: Mon, 12 Jul 2021 13:50:32 -0400 [thread overview]
Message-ID: <20210712175032.GB502004@redhat.com> (raw)
In-Reply-To: <YOizURuWJO9DYGGk@mit.edu>
On Fri, Jul 09, 2021 at 04:36:33PM -0400, Theodore Ts'o wrote:
> On Fri, Jul 09, 2021 at 08:34:41AM -0700, Casey Schaufler wrote:
> > >> One question, do all filesystem supporting xattrs deal with setting them
> > >> on symlinks/device files correctly?
> > > Wrote a simple bash script to do setfattr/getfattr user.foo xattr on
> > > symlink and device node on ext4, xfs and btrfs and it works fine.
> >
> > How about nfs, tmpfs, overlayfs and/or some of the other less conventional
> > filesystems?
>
> As a suggestion, perhaps you could take your bash script and turn it
> into an xfstests test so we can more easily test various file systems,
> both now and once the commit is accepted, to look for regressions?
Sounds good. I see there is already an xattr test (generic/062) which
is broken after my patch. Current test expects that user.* xattrs will
fail on symlink/special device.
I will probably have to query kernel version and modify test so that
expect failure before a certain version and success otherwise.
Thanks
Vivek
next prev parent reply other threads:[~2021-07-12 17:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 17:57 [RFC PATCH v2 0/1] Relax restrictions on user.* xattr Vivek Goyal
2021-07-08 17:57 ` [PATCH v2 1/1] xattr: Allow user.* xattr on symlink and special files Vivek Goyal
2021-07-09 9:19 ` Christian Brauner
2021-07-09 15:27 ` Vivek Goyal
2021-07-09 15:34 ` Casey Schaufler
2021-07-09 17:59 ` Vivek Goyal
2021-07-09 20:10 ` Bruce Fields
2021-07-12 14:02 ` Vivek Goyal
2021-07-12 15:41 ` J. Bruce Fields
2021-07-12 17:47 ` Vivek Goyal
2021-07-12 19:31 ` J. Bruce Fields
2021-07-12 21:22 ` Vivek Goyal
2021-07-13 14:17 ` Casey Schaufler
2021-08-30 18:45 ` Vivek Goyal
2021-07-09 20:36 ` Theodore Ts'o
2021-07-12 17:50 ` Vivek Goyal [this message]
2021-07-12 12:49 ` [Virtio-fs] " Greg Kurz
2021-07-13 14:28 ` Casey Schaufler
2021-07-09 16:00 ` [RFC PATCH v2 0/1] Relax restrictions on user.* xattr Daniel Walsh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712175032.GB502004@redhat.com \
--to=vgoyal@redhat.com \
--cc=casey.schaufler@intel.com \
--cc=casey@schaufler-ca.com \
--cc=christian.brauner@ubuntu.com \
--cc=dgilbert@redhat.com \
--cc=dwalsh@redhat.com \
--cc=gscrivan@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=selinux@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).