linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
	Punit Agrawal <punit.agrawal@bytedance.com>
Subject: [PATCH 1/6] mm: Allow per-VMA locks on file-backed VMAs
Date: Tue,  4 Apr 2023 14:58:45 +0100	[thread overview]
Message-ID: <20230404135850.3673404-2-willy@infradead.org> (raw)
In-Reply-To: <20230404135850.3673404-1-willy@infradead.org>

The fault path will immediately fail in handle_mm_fault(), so this
is the minimal step which allows the per-VMA lock to be taken on
file-backed VMAs.  There may be a small performance reduction as a
little unnecessary work will be done on each page fault.  See later
patches for the improvement.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 mm/memory.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/mm/memory.c b/mm/memory.c
index fdaec7772fff..f726f85f0081 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -5223,6 +5223,9 @@ vm_fault_t handle_mm_fault(struct vm_area_struct *vma, unsigned long address,
 					    flags & FAULT_FLAG_REMOTE))
 		return VM_FAULT_SIGSEGV;
 
+	if ((flags & FAULT_FLAG_VMA_LOCK) && !vma_is_anonymous(vma))
+		return VM_FAULT_RETRY;
+
 	/*
 	 * Enable the memcg OOM handling for faults triggered in user
 	 * space.  Kernel faults are handled more gracefully.
@@ -5275,12 +5278,8 @@ struct vm_area_struct *lock_vma_under_rcu(struct mm_struct *mm,
 	if (!vma)
 		goto inval;
 
-	/* Only anonymous vmas are supported for now */
-	if (!vma_is_anonymous(vma))
-		goto inval;
-
 	/* find_mergeable_anon_vma uses adjacent vmas which are not locked */
-	if (!vma->anon_vma)
+	if (vma_is_anonymous(vma) && !vma->anon_vma)
 		goto inval;
 
 	if (!vma_start_read(vma))
-- 
2.39.2


  reply	other threads:[~2023-04-04 14:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04 13:58 [PATCH 0/6] Avoid the mmap lock for fault-around Matthew Wilcox (Oracle)
2023-04-04 13:58 ` Matthew Wilcox (Oracle) [this message]
2023-04-07 17:54   ` [PATCH 1/6] mm: Allow per-VMA locks on file-backed VMAs Suren Baghdasaryan
2023-04-07 20:12     ` Matthew Wilcox
2023-04-07 20:26       ` Suren Baghdasaryan
2023-04-07 21:36         ` Matthew Wilcox
2023-04-07 22:40           ` Suren Baghdasaryan
2023-04-07 22:49             ` Suren Baghdasaryan
2023-04-14 18:02           ` Suren Baghdasaryan
2023-04-04 13:58 ` [PATCH 2/6] mm: Move FAULT_FLAG_VMA_LOCK check from handle_mm_fault() Matthew Wilcox (Oracle)
2023-04-04 13:58 ` [PATCH 3/6] mm: Move FAULT_FLAG_VMA_LOCK check into handle_pte_fault() Matthew Wilcox (Oracle)
2023-04-04 13:58 ` [PATCH 4/6] mm: Move FAULT_FLAG_VMA_LOCK check down in handle_pte_fault() Matthew Wilcox (Oracle)
2023-04-04 13:58 ` [PATCH 5/6] mm: Move the FAULT_FLAG_VMA_LOCK check down from do_pte_missing() Matthew Wilcox (Oracle)
2023-04-04 13:58 ` [PATCH 6/6] mm: Run the fault-around code under the VMA lock Matthew Wilcox (Oracle)
2023-04-04 15:23   ` Matthew Wilcox
2023-04-07 18:20     ` Suren Baghdasaryan
2023-04-10  4:53     ` Yin, Fengwei
2023-04-10 14:11       ` Matthew Wilcox
2023-04-12  7:35         ` Yin, Fengwei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230404135850.3673404-2-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=punit.agrawal@bytedance.com \
    --cc=surenb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).