From: Suren Baghdasaryan <surenb@google.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
Punit Agrawal <punit.agrawal@bytedance.com>
Subject: Re: [PATCH 1/6] mm: Allow per-VMA locks on file-backed VMAs
Date: Fri, 14 Apr 2023 11:02:57 -0700 [thread overview]
Message-ID: <CAJuCfpGxQMEuvg1FgT0BRDdWF8kzah4BLCNfGdByFjVHyDrQLw@mail.gmail.com> (raw)
In-Reply-To: <ZDCM8hGnqgsHyP0a@casper.infradead.org>
On Fri, Apr 7, 2023 at 2:36 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Fri, Apr 07, 2023 at 01:26:08PM -0700, Suren Baghdasaryan wrote:
> > True. do_swap_page() has the same issue. Can we move these
> > count_vm_event() calls to the end of handle_mm_fault():
>
> I was going to suggest something similar, so count that as an
> Acked-by. This will change the accounting for the current retry
> situation, where we drop the mmap_lock in filemap_fault(), initiate I/O
> and return RETRY. I think that's probably a good change though; I don't
> see why applications should have their fault counters incremented twice
> for that situation.
>
> > mm_account_fault(regs, address, flags, ret);
> > +out:
> > + if (ret != VM_FAULT_RETRY) {
> > + count_vm_event(PGFAULT);
> > + count_memcg_event_mm(vma->vm_mm, PGFAULT);
> > + }
>
> Nit: this is a bitmask, so we should probably have:
>
> if (!(ret & VM_FAULT_RETRY)) {
>
> in case somebody's ORed it with VM_FAULT_MAJOR or something.
The fix is posted at
https://lore.kernel.org/all/20230414175444.1837474-1-surenb@google.com/
>
> Hm, I wonder if we're handling that correctly; if we need to start I/O,
> do we preserve VM_FAULT_MAJOR returned from the first attempt? Not
> in a position where I can look at the code right now.
next prev parent reply other threads:[~2023-04-14 18:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 13:58 [PATCH 0/6] Avoid the mmap lock for fault-around Matthew Wilcox (Oracle)
2023-04-04 13:58 ` [PATCH 1/6] mm: Allow per-VMA locks on file-backed VMAs Matthew Wilcox (Oracle)
2023-04-07 17:54 ` Suren Baghdasaryan
2023-04-07 20:12 ` Matthew Wilcox
2023-04-07 20:26 ` Suren Baghdasaryan
2023-04-07 21:36 ` Matthew Wilcox
2023-04-07 22:40 ` Suren Baghdasaryan
2023-04-07 22:49 ` Suren Baghdasaryan
2023-04-14 18:02 ` Suren Baghdasaryan [this message]
2023-04-04 13:58 ` [PATCH 2/6] mm: Move FAULT_FLAG_VMA_LOCK check from handle_mm_fault() Matthew Wilcox (Oracle)
2023-04-04 13:58 ` [PATCH 3/6] mm: Move FAULT_FLAG_VMA_LOCK check into handle_pte_fault() Matthew Wilcox (Oracle)
2023-04-04 13:58 ` [PATCH 4/6] mm: Move FAULT_FLAG_VMA_LOCK check down in handle_pte_fault() Matthew Wilcox (Oracle)
2023-04-04 13:58 ` [PATCH 5/6] mm: Move the FAULT_FLAG_VMA_LOCK check down from do_pte_missing() Matthew Wilcox (Oracle)
2023-04-04 13:58 ` [PATCH 6/6] mm: Run the fault-around code under the VMA lock Matthew Wilcox (Oracle)
2023-04-04 15:23 ` Matthew Wilcox
2023-04-07 18:20 ` Suren Baghdasaryan
2023-04-10 4:53 ` Yin, Fengwei
2023-04-10 14:11 ` Matthew Wilcox
2023-04-12 7:35 ` Yin, Fengwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJuCfpGxQMEuvg1FgT0BRDdWF8kzah4BLCNfGdByFjVHyDrQLw@mail.gmail.com \
--to=surenb@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=punit.agrawal@bytedance.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).