From: Keiichi Watanabe <keiichiw@chromium.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: mhiramat@google.com, takayas@chromium.org, drosen@google.com,
sarthakkukreti@google.com, uekawa@chromium.org,
Keiichi Watanabe <keiichiw@chromium.org>,
Jonathan Corbet <corbet@lwn.net>,
Miklos Szeredi <miklos@szeredi.hu>,
Stefan Hajnoczi <stefanha@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: [PATCH 0/3] Support negative dentry cache for FUSE and virtiofs
Date: Wed, 21 Jun 2023 00:13:13 +0900 [thread overview]
Message-ID: <20230620151328.1637569-1-keiichiw@chromium.org> (raw)
This patch series adds a new mount option called negative_dentry_timeout
for FUSE and virtio-fs filesystems. This option allows the kernel to cache
negative dentries, which are dentries that represent a non-existent file.
When this option is enabled, the kernel will skip FUSE_LOOKUP requests for
second and subsequent lookups to a non-existent file.
Unlike negative dentry caches on a normal filesystem such as ext4, the
kernel may need to refresh the cache for FUSE and virtio-fs filesystems.
This is because the kernel does not know when a FUSE server or a virtio-fs
device creates or deletes files. To address this, the new
negative_dentry_timeout option takes an expiration time for cache entries.
The appropriate timeout duration should be determined by considering how
often a FUSE server updates file paths and the amount of memory the kernel
can use for the cache.
As we evaluated the virtio-fs's performance on a guest Linux on crosvm
[1]'s virtiofs device[2], the `negative_dentry_timeout` option saved ~1
second per 10000 `stat` call against a non-existent path. The experiment
settings and results are as follows:
* Command to start VM with crosvm:
sudo crosvm run \
--disable-sandbox \
--cpus 1 \
--mem 2048 \
--rwroot debian.img \
--shared-dir \
/path/:my_virtiofs:type=fs:cache=always:timeout=3600 \
-p "console=hvc0 init=/bin/bash" \
vmlinux
* Mount command in the guest
Default:
$ mount -t virtiofs my_virtiofs ./workspace/
With negative dentry cache:
$ mount -t virtiofs -o negative_dentry_timeout=10 my_virtiofs ./workspace/
* Test commands
$ cd workspace
$ echo 3 > /proc/sys/vm/drop_caches
$ time for i in `seq 1 10000`; \
do stat non-existent.txt 2> /dev/null; \
done
* Results:
Default:
real 0m12.606s
user 0m3.624s
sys 0m7.756s
With `-o negative_dentry_timeout=10`:
real 0m11.276s
user 0m3.514s
sys 0m7.544s
[1]: https://crosvm.dev/book/
[2]: https://crosvm.dev/book/devices/fs.html
Keiichi Watanabe (3):
docs: virtiofs: Fix descriptions about virtiofs mount option
fuse: Add negative_dentry_timeout option
virtiofs: Add negative_dentry_timeout option
Documentation/filesystems/dax.rst | 1 +
Documentation/filesystems/fuse.rst | 6 ++++++
Documentation/filesystems/virtiofs.rst | 9 ++++++++-
fs/fuse/dir.c | 3 ++-
fs/fuse/fuse_i.h | 4 ++++
fs/fuse/inode.c | 12 +++++++++++-
fs/fuse/virtio_fs.c | 8 ++++++++
7 files changed, 40 insertions(+), 3 deletions(-)
--
2.41.0.185.g7c58973941-goog
next reply other threads:[~2023-06-20 15:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 15:13 Keiichi Watanabe [this message]
2023-06-20 15:13 ` [PATCH 1/3] docs: virtiofs: Fix descriptions about virtiofs mount option Keiichi Watanabe
2023-06-20 15:13 ` [PATCH 2/3] fuse: Add negative_dentry_timeout option Keiichi Watanabe
2023-06-20 19:28 ` Miklos Szeredi
[not found] ` <CADgJSGGDeu_dPduBuK7N324oJ9641VKv2+fAVAbDY=-itsFjEQ@mail.gmail.com>
2023-06-21 4:07 ` Miklos Szeredi
2023-06-21 9:40 ` Keiichi Watanabe
2023-06-20 15:13 ` [PATCH 3/3] virtiofs: " Keiichi Watanabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230620151328.1637569-1-keiichiw@chromium.org \
--to=keiichiw@chromium.org \
--cc=corbet@lwn.net \
--cc=drosen@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@google.com \
--cc=miklos@szeredi.hu \
--cc=sarthakkukreti@google.com \
--cc=stefanha@redhat.com \
--cc=takayas@chromium.org \
--cc=uekawa@chromium.org \
--cc=vgoyal@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).