From: Keiichi Watanabe <keiichiw@chromium.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: mhiramat@google.com, takayas@chromium.org, drosen@google.com,
sarthakkukreti@google.com, uekawa@chromium.org,
Keiichi Watanabe <keiichiw@chromium.org>,
Jonathan Corbet <corbet@lwn.net>,
Miklos Szeredi <miklos@szeredi.hu>,
Stefan Hajnoczi <stefanha@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: [PATCH 3/3] virtiofs: Add negative_dentry_timeout option
Date: Wed, 21 Jun 2023 00:13:16 +0900 [thread overview]
Message-ID: <20230620151328.1637569-4-keiichiw@chromium.org> (raw)
In-Reply-To: <20230620151328.1637569-1-keiichiw@chromium.org>
Add negative_dentry_timeout mount option to virtiofs to caching negative
dentry on the guest side. When the host virito-fs device has an exclusive
access to the file system and the machine has enough memory, one can
specify a long time as the timeout.
This option saves ~1 second per 10,000 stat request for non-existing paths.
Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
---
Documentation/filesystems/virtiofs.rst | 4 ++++
fs/fuse/virtio_fs.c | 8 ++++++++
2 files changed, 12 insertions(+)
diff --git a/Documentation/filesystems/virtiofs.rst b/Documentation/filesystems/virtiofs.rst
index fdec5a7840f7..b045ef2223de 100644
--- a/Documentation/filesystems/virtiofs.rst
+++ b/Documentation/filesystems/virtiofs.rst
@@ -48,6 +48,10 @@ ro, rw, context, etc. Also, virtiofs has its own options.
dax[=always,never,inode]
Enable direct access for files. See :ref:`virtiofs-dax`.
+negative_dentry_timeout=N
+ Set the time in seconds to keep negative dentry cache. Same as the FUSE's
+ mount option.
+
atime behavior
^^^^^^^^^^^^^^
diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
index 4d8d4f16c727..bbbd840510f9 100644
--- a/fs/fuse/virtio_fs.c
+++ b/fs/fuse/virtio_fs.c
@@ -99,11 +99,13 @@ static const struct constant_table dax_param_enums[] = {
enum {
OPT_DAX,
OPT_DAX_ENUM,
+ OPT_NEGATIVE_DENTRY_TIMEOUT,
};
static const struct fs_parameter_spec virtio_fs_parameters[] = {
fsparam_flag("dax", OPT_DAX),
fsparam_enum("dax", OPT_DAX_ENUM, dax_param_enums),
+ fsparam_u32 ("negative_dentry_timeout", OPT_NEGATIVE_DENTRY_TIMEOUT),
{}
};
@@ -125,6 +127,9 @@ static int virtio_fs_parse_param(struct fs_context *fsc,
case OPT_DAX_ENUM:
ctx->dax_mode = result.uint_32;
break;
+ case OPT_NEGATIVE_DENTRY_TIMEOUT:
+ ctx->negative_dentry_timeout = result.uint_32;
+ break;
default:
return -EINVAL;
}
@@ -1416,6 +1421,7 @@ static int virtio_fs_get_tree(struct fs_context *fsc)
struct super_block *sb;
struct fuse_conn *fc = NULL;
struct fuse_mount *fm;
+ struct fuse_fs_context *ffc;
unsigned int virtqueue_size;
int err = -EIO;
@@ -1468,6 +1474,8 @@ static int virtio_fs_get_tree(struct fs_context *fsc)
sb->s_flags |= SB_ACTIVE;
}
+ ffc = fsc->fs_private;
+ fm->negative_dentry_timeout = ffc->negative_dentry_timeout;
WARN_ON(fsc->root);
fsc->root = dget(sb->s_root);
--
2.41.0.185.g7c58973941-goog
prev parent reply other threads:[~2023-06-20 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 15:13 [PATCH 0/3] Support negative dentry cache for FUSE and virtiofs Keiichi Watanabe
2023-06-20 15:13 ` [PATCH 1/3] docs: virtiofs: Fix descriptions about virtiofs mount option Keiichi Watanabe
2023-06-20 15:13 ` [PATCH 2/3] fuse: Add negative_dentry_timeout option Keiichi Watanabe
2023-06-20 19:28 ` Miklos Szeredi
[not found] ` <CADgJSGGDeu_dPduBuK7N324oJ9641VKv2+fAVAbDY=-itsFjEQ@mail.gmail.com>
2023-06-21 4:07 ` Miklos Szeredi
2023-06-21 9:40 ` Keiichi Watanabe
2023-06-20 15:13 ` Keiichi Watanabe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230620151328.1637569-4-keiichiw@chromium.org \
--to=keiichiw@chromium.org \
--cc=corbet@lwn.net \
--cc=drosen@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@google.com \
--cc=miklos@szeredi.hu \
--cc=sarthakkukreti@google.com \
--cc=stefanha@redhat.com \
--cc=takayas@chromium.org \
--cc=uekawa@chromium.org \
--cc=vgoyal@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).