From: Avadhut Naik <avadhut.naik@amd.com>
To: <rafael@kernel.org>, <gregkh@linuxfoundation.org>,
<lenb@kernel.org>, <linux-acpi@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>
Cc: <yazen.ghannam@amd.com>, <alexey.kardashevskiy@amd.com>,
<linux-kernel@vger.kernel.org>, <avadnaik@amd.com>
Subject: [PATCH v4 0/4] Add support for Vendor Defined Error Types in Einj Module
Date: Wed, 21 Jun 2023 03:50:58 +0000 [thread overview]
Message-ID: <20230621035102.13463-1-avadhut.naik@amd.com> (raw)
From: Avadhut Naik <Avadhut.Naik@amd.com>
This patchset adds support for Vendor Defined Error types in the einj
module by exporting a binary blob file in module's debugfs directory.
Userspace tools can write OEM Defined Structures into the blob file as
part of injecting Vendor defined errors.
The first patch refactors available_error_type_show() function to ensure
all errors supported by the platform are output through einj module's
available_error_type file in debugfs.
The second patch adds a write callback for binary blobs created through
debugfs_create_blob() API.
The third patch fixes the permissions of panicinfo file in debugfs to
ensure it remains read-only
The fourth patch adds the required support i.e. establishing the memory
mapping and exporting it through debugfs blob file for Vendor-defined
Error types.
Changes in v2:
- Split the v1 patch, as was recommended, to have a separate patch for
changes in debugfs.
- Refactored available_error_type_show() function into a separate patch.
- Changed file permissions to octal format to remove checkpatch warnings.
Changes in v3:
- Use BIT macro for generating error masks instead of hex values since
ACPI spec uses bit numbers.
- Handle the corner case of acpi_os_map_iomem() returning NULL through
a local variable to a store the size of OEM defined data structure.
Changes in v4:
- Fix permissions for panicinfo file in debugfs.
- Replace acpi_os_map_iomem() and acpi_os_unmap_iomem() calls with
acpi_os_map_memory() and acpi_os_unmap_memory() respectively to avert
sparse warnings as suggested by Alexey.
Avadhut Naik (4):
ACPI: APEI: EINJ: Refactor available_error_type_show()
fs: debugfs: Add write functionality to debugfs blobs
platform/chrome: cros_ec_debugfs: Fix permissions for panicinfo
ACPI: APEI: EINJ: Add support for vendor defined error types
drivers/acpi/apei/einj.c | 67 ++++++++++++++++-------
drivers/platform/chrome/cros_ec_debugfs.c | 2 +-
fs/debugfs/file.c | 28 ++++++++--
3 files changed, 70 insertions(+), 27 deletions(-)
--
2.34.1
next reply other threads:[~2023-06-21 3:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 3:50 Avadhut Naik [this message]
2023-06-21 3:50 ` [PATCH v4 1/4] ACPI: APEI: EINJ: Refactor available_error_type_show() Avadhut Naik
2023-06-21 3:51 ` [PATCH v4 2/4] fs: debugfs: Add write functionality to debugfs blobs Avadhut Naik
2023-06-23 8:09 ` Greg KH
2023-06-21 3:51 ` [PATCH v4 3/4] platform/chrome: cros_ec_debugfs: Fix permissions for panicinfo Avadhut Naik
2023-06-23 8:09 ` Greg KH
2023-06-21 3:51 ` [PATCH v4 4/4] ACPI: APEI: EINJ: Add support for vendor defined error types Avadhut Naik
2023-08-11 5:18 ` [PATCH v4 0/4] Add support for Vendor Defined Error Types in Einj Module Avadhut Naik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621035102.13463-1-avadhut.naik@amd.com \
--to=avadhut.naik@amd.com \
--cc=alexey.kardashevskiy@amd.com \
--cc=avadnaik@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).