From: Greg KH <gregkh@linuxfoundation.org>
To: Avadhut Naik <avadhut.naik@amd.com>
Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-fsdevel@vger.kernel.org, yazen.ghannam@amd.com,
alexey.kardashevskiy@amd.com, linux-kernel@vger.kernel.org,
avadnaik@amd.com
Subject: Re: [PATCH v4 3/4] platform/chrome: cros_ec_debugfs: Fix permissions for panicinfo
Date: Fri, 23 Jun 2023 10:09:09 +0200 [thread overview]
Message-ID: <2023062357-deceased-rejoicing-03d6@gregkh> (raw)
In-Reply-To: <20230621035102.13463-4-avadhut.naik@amd.com>
On Wed, Jun 21, 2023 at 03:51:01AM +0000, Avadhut Naik wrote:
> From: Avadhut Naik <Avadhut.Naik@amd.com>
>
> The debugfs_create_blob() function has been used to create read-only binary
> blobs in debugfs. The function filters out permissions, other than S_IRUSR,
> S_IRGRP and S_IROTH, provided while creating the blobs.
>
> The very behavior though is being changed through previous patch in the
> series (fs: debugfs: Add write functionality to debugfs blobs) which makes
> the binary blobs writable.
>
> As such, rectify the permissions of panicinfo file to ensure it remains
> read-only.
>
> Signed-off-by: Avadhut Naik <Avadhut.Naik@amd.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2023-06-23 8:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 3:50 [PATCH v4 0/4] Add support for Vendor Defined Error Types in Einj Module Avadhut Naik
2023-06-21 3:50 ` [PATCH v4 1/4] ACPI: APEI: EINJ: Refactor available_error_type_show() Avadhut Naik
2023-06-21 3:51 ` [PATCH v4 2/4] fs: debugfs: Add write functionality to debugfs blobs Avadhut Naik
2023-06-23 8:09 ` Greg KH
2023-06-21 3:51 ` [PATCH v4 3/4] platform/chrome: cros_ec_debugfs: Fix permissions for panicinfo Avadhut Naik
2023-06-23 8:09 ` Greg KH [this message]
2023-06-21 3:51 ` [PATCH v4 4/4] ACPI: APEI: EINJ: Add support for vendor defined error types Avadhut Naik
2023-08-11 5:18 ` [PATCH v4 0/4] Add support for Vendor Defined Error Types in Einj Module Avadhut Naik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023062357-deceased-rejoicing-03d6@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexey.kardashevskiy@amd.com \
--cc=avadhut.naik@amd.com \
--cc=avadnaik@amd.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).