linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Willy Tarreau <w@1wt.eu>, Shuah Khan <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, "Zhangjin Wu" <falcon@tinylab.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Thomas Weißschuh" <linux@weissschuh.net>
Subject: [PATCH 1/2] selftests/nolibc: drop test chmod_net
Date: Sat, 24 Jun 2023 12:30:46 +0200	[thread overview]
Message-ID: <20230624-proc-net-setattr-v1-1-73176812adee@weissschuh.net> (raw)
In-Reply-To: <20230624-proc-net-setattr-v1-0-73176812adee@weissschuh.net>

The test relies on /proc/$PID/net to allow chmod() operations.
It is the only file or directory in /proc/$PID/ to allow this and a bug.
That bug will be fixed in the next patch in the series and therefore
the test would start failing.

Link: https://lore.kernel.org/lkml/d0d111ef-edae-4760-83fb-36db84278da1@t-8ch.de/
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 tools/testing/selftests/nolibc/nolibc-test.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
index 21bacc928bf7..7e649814a241 100644
--- a/tools/testing/selftests/nolibc/nolibc-test.c
+++ b/tools/testing/selftests/nolibc/nolibc-test.c
@@ -512,7 +512,6 @@ int run_syscall(int min, int max)
 		CASE_TEST(chdir_root);        EXPECT_SYSZR(1, chdir("/")); break;
 		CASE_TEST(chdir_dot);         EXPECT_SYSZR(1, chdir(".")); break;
 		CASE_TEST(chdir_blah);        EXPECT_SYSER(1, chdir("/blah"), -1, ENOENT); break;
-		CASE_TEST(chmod_net);         EXPECT_SYSZR(proc, chmod("/proc/self/net", 0555)); break;
 		CASE_TEST(chmod_self);        EXPECT_SYSER(proc, chmod("/proc/self", 0555), -1, EPERM); break;
 		CASE_TEST(chown_self);        EXPECT_SYSER(proc, chown("/proc/self", 0, 0), -1, EPERM); break;
 		CASE_TEST(chroot_root);       EXPECT_SYSZR(euid0, chroot("/")); break;

-- 
2.41.0


  reply	other threads:[~2023-06-24 10:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-24 10:30 [PATCH 0/2] proc: proc_setattr for /proc/$PID/net Thomas Weißschuh
2023-06-24 10:30 ` Thomas Weißschuh [this message]
2023-06-24 10:30 ` [PATCH 2/2] proc: use generic setattr() " Thomas Weißschuh
2023-07-13 11:49   ` Christian Brauner
2023-06-30 14:06 ` [PATCH 0/2] proc: proc_setattr " Zhangjin Wu
2023-07-09  9:29   ` Willy Tarreau
2023-07-09 17:10     ` Thomas Weißschuh
2023-07-09 17:27       ` Willy Tarreau
2023-07-09 17:57         ` Thomas Weißschuh
2023-07-09 18:04           ` Willy Tarreau
2023-07-09 18:22             ` Thomas Weißschuh
2023-07-10  7:09               ` Willy Tarreau
2023-07-10  7:36                 ` Thomas Weißschuh
2023-07-13 11:51       ` Christian Brauner
2023-07-13 12:04         ` Thomas Weißschuh
2023-07-13 11:58 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230624-proc-net-setattr-v1-1-73176812adee@weissschuh.net \
    --to=linux@weissschuh.net \
    --cc=arnd@arndb.de \
    --cc=falcon@tinylab.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).