From: Zhangjin Wu <falcon@tinylab.org>
To: linux@weissschuh.net
Cc: arnd@arndb.de, falcon@tinylab.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
shuah@kernel.org, w@1wt.eu
Subject: [PATCH 0/2] proc: proc_setattr for /proc/$PID/net
Date: Fri, 30 Jun 2023 22:06:09 +0800 [thread overview]
Message-ID: <20230630140609.263790-1-falcon@tinylab.org> (raw)
In-Reply-To: <20230624-proc-net-setattr-v1-0-73176812adee@weissschuh.net>
Hi, Thomas
Just applied your patchset on v6.4, and then:
- revert the 1st patch: 'selftests/nolibc: drop test chmod_net' manually
- do the 'run' test of nolibc on arm/vexpress-a9
The 'chmod_net' test of tools/testing/selftests/nolibc/nolibc-test.c
really failed as expected (and therefore, should be removed):
11 chdir_root = 0 [OK]
12 chdir_dot = 0 [OK]
13 chdir_blah = -1 ENOENT [OK]
14 chmod_net = -1 EPERM [FAIL]
15 chmod_self = -1 EPERM [OK]
16 chmod_tmpdir = 0 [OK]
17 chown_self = -1 EPERM [OK]
So, If this test result is enough for this patch, here is my:
Tested-by: Zhangjin Wu <falcon@tinylab.org>
Best regards,
Zhangjin
> /proc/$PID/net currently allows the setting of file attributes,
> in contrast to other /proc/$PID/ files and directories.
>
> This would break the nolibc testsuite so the first patch in the series
> removes the offending testcase.
> The "fix" for nolibc-test is intentionally kept trivial as the series
> will most likely go through the filesystem tree and if conflicts arise,
> it is obvious on how to resolve them.
>
> Technically this can lead to breakage of nolibc-test if an old
> nolibc-test is used with a newer kernel containing the fix.
>
> Note:
>
> Except for /proc itself this is the only "struct inode_operations" in
> fs/proc/ that is missing an implementation of setattr().
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Thomas Weißschuh (2):
> selftests/nolibc: drop test chmod_net
> proc: use generic setattr() for /proc/$PID/net
>
> fs/proc/proc_net.c | 1 +
> tools/testing/selftests/nolibc/nolibc-test.c | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
> ---
> base-commit: a92b7d26c743b9dc06d520f863d624e94978a1d9
> change-id: 20230624-proc-net-setattr-8f0a6b8eb2f5
>
> Best regards,
> --
> Thomas Weißschuh <linux@weissschuh.net>
next prev parent reply other threads:[~2023-06-30 14:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 10:30 [PATCH 0/2] proc: proc_setattr for /proc/$PID/net Thomas Weißschuh
2023-06-24 10:30 ` [PATCH 1/2] selftests/nolibc: drop test chmod_net Thomas Weißschuh
2023-06-24 10:30 ` [PATCH 2/2] proc: use generic setattr() for /proc/$PID/net Thomas Weißschuh
2023-07-13 11:49 ` Christian Brauner
2023-06-30 14:06 ` Zhangjin Wu [this message]
2023-07-09 9:29 ` [PATCH 0/2] proc: proc_setattr " Willy Tarreau
2023-07-09 17:10 ` Thomas Weißschuh
2023-07-09 17:27 ` Willy Tarreau
2023-07-09 17:57 ` Thomas Weißschuh
2023-07-09 18:04 ` Willy Tarreau
2023-07-09 18:22 ` Thomas Weißschuh
2023-07-10 7:09 ` Willy Tarreau
2023-07-10 7:36 ` Thomas Weißschuh
2023-07-13 11:51 ` Christian Brauner
2023-07-13 12:04 ` Thomas Weißschuh
2023-07-13 11:58 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630140609.263790-1-falcon@tinylab.org \
--to=falcon@tinylab.org \
--cc=arnd@arndb.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=shuah@kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).