* [PATCH v1] virt: kvm: Replace define function
@ 2023-07-06 7:29 Minjie Du
2023-07-10 16:51 ` Sean Christopherson
0 siblings, 1 reply; 2+ messages in thread
From: Minjie Du @ 2023-07-06 7:29 UTC (permalink / raw)
To: linux-fsdevel, Paolo Bonzini,
open list:KERNEL VIRTUAL MACHINE (KVM),
open list
Cc: Minjie Du
Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE.
Signed-off-by: Minjie Du <duminjie@vivo.com>
---
virt/kvm/kvm_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index dfbaafbe3..ec1fabfbd 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -3880,7 +3880,7 @@ static int vcpu_get_pid(void *data, u64 *val)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(vcpu_get_pid_fops, vcpu_get_pid, NULL, "%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(vcpu_get_pid_fops, vcpu_get_pid, NULL, "%llu\n");
static void kvm_create_vcpu_debugfs(struct kvm_vcpu *vcpu)
{
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] virt: kvm: Replace define function
2023-07-06 7:29 [PATCH v1] virt: kvm: Replace define function Minjie Du
@ 2023-07-10 16:51 ` Sean Christopherson
0 siblings, 0 replies; 2+ messages in thread
From: Sean Christopherson @ 2023-07-10 16:51 UTC (permalink / raw)
To: Minjie Du
Cc: linux-fsdevel, Paolo Bonzini,
open list:KERNEL VIRTUAL MACHINE (KVM),
open list
On Thu, Jul 06, 2023, Minjie Du wrote:
> Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE.
NAK. I'm sending a patch to revert 5103068eaca2 ("debugfs, coccinelle: check for
obsolete DEFINE_SIMPLE_ATTRIBUTE() usage"), this is beyond ridiculous.
https://lore.kernel.org/all/Y3PPCHa9Yzi1sSnQ@google.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-10 16:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-06 7:29 [PATCH v1] virt: kvm: Replace define function Minjie Du
2023-07-10 16:51 ` Sean Christopherson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).