* [PATCH] pidfd: make pidfs_dentry_operations static
@ 2024-02-22 8:36 Jiapeng Chong
2024-02-22 8:45 ` Christian Brauner
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2024-02-22 8:36 UTC (permalink / raw)
To: viro
Cc: brauner, jack, linux-fsdevel, linux-kernel, Jiapeng Chong, Abaci Robot
The pidfs_dentry_operations are not used outside the file pidfs.c, so the
modification is defined as static.
fs/pidfs.c:175:32: warning: symbol 'pidfs_dentry_operations' was not declared. Should it be static?
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8284
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/pidfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/pidfs.c b/fs/pidfs.c
index c33501c9cd8b..85e9617f0aee 100644
--- a/fs/pidfs.c
+++ b/fs/pidfs.c
@@ -172,7 +172,7 @@ static void pidfdfs_prune_dentry(struct dentry *dentry)
}
}
-const struct dentry_operations pidfs_dentry_operations = {
+static const struct dentry_operations pidfs_dentry_operations = {
.d_delete = always_delete_dentry,
.d_dname = pidfs_dname,
.d_prune = pidfdfs_prune_dentry,
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pidfd: make pidfs_dentry_operations static
2024-02-22 8:36 [PATCH] pidfd: make pidfs_dentry_operations static Jiapeng Chong
@ 2024-02-22 8:45 ` Christian Brauner
0 siblings, 0 replies; 2+ messages in thread
From: Christian Brauner @ 2024-02-22 8:45 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: viro, jack, linux-fsdevel, linux-kernel, Abaci Robot
Already fixed. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-22 8:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-22 8:36 [PATCH] pidfd: make pidfs_dentry_operations static Jiapeng Chong
2024-02-22 8:45 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).