From: Christian Brauner <brauner@kernel.org>
To: Luis Henriques <lhenriques@suse.de>
Cc: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jan Kara <jack@suse.cz>, Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ext4: fix mount parameters check for empty values
Date: Fri, 1 Mar 2024 14:36:55 +0100 [thread overview]
Message-ID: <20240301-spalten-impfschutz-4118b8fcf5b3@brauner> (raw)
In-Reply-To: <20240229163011.16248-3-lhenriques@suse.de>
On Thu, Feb 29, 2024 at 04:30:09PM +0000, Luis Henriques wrote:
> Now that parameters that have the flag 'fs_param_can_be_empty' set and
> their value is NULL are handled as 'flag' type, we need to properly check
> for empty (NULL) values.
>
> Signed-off-by: Luis Henriques <lhenriques@suse.de>
> ---
> fs/ext4/super.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 0f931d0c227d..44ba2212dfb3 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -2183,12 +2183,12 @@ static int ext4_parse_param(struct fs_context *fc, struct fs_parameter *param)
> switch (token) {
> #ifdef CONFIG_QUOTA
> case Opt_usrjquota:
> - if (!*param->string)
> + if (!param->string)
> return unnote_qf_name(fc, USRQUOTA);
I fail to understand how that can happen. Currently both of these
options are parsed as strings via:
#define fsparam_string_empty(NAME, OPT) \
__fsparam(fs_param_is_string, NAME, OPT, fs_param_can_be_empty, NULL)
So if someone sets fsconfig(..., FSCONFIG_SET_STRING, "usrquota", NULL, ...)
we give an immediate
case FSCONFIG_SET_STRING:
if (!_key || !_value || aux) return -EINVAL;
from fsconfig() so we know that param->string cannot be NULL. If that
were the case we'd NULL deref in fs_param_is_string():
int fs_param_is_string(struct p_log *log, const struct fs_parameter_spec *p,
struct fs_parameter *param, struct fs_parse_result *result)
{
if (param->type != fs_value_is_string ||
(!*param->string && !(p->flags & fs_param_can_be_empty)))
So you're check above seems wrong. If I'm mistaken, please explain, how
this can happen in detail.
next prev parent reply other threads:[~2024-03-01 13:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 16:30 [PATCH 0/3] fs_parser: handle parameters that can be empty and don't have a value Luis Henriques
2024-02-29 16:30 ` [PATCH 1/3] " Luis Henriques
2024-03-01 13:31 ` Christian Brauner
2024-03-01 15:45 ` Luis Henriques
2024-03-02 11:46 ` Christian Brauner
2024-03-02 17:56 ` Christian Brauner
2024-03-03 21:31 ` Luis Henriques
2024-03-04 9:04 ` Christian Brauner
2024-03-03 21:17 ` Luis Henriques
2024-03-07 15:13 ` Jan Kara
2024-03-08 9:53 ` Christian Brauner
2024-03-08 10:12 ` Luis Henriques
2024-03-08 23:09 ` Jan Kara
2024-03-11 10:26 ` Luis Henriques
2024-03-11 16:01 ` Jan Kara
2024-02-29 16:30 ` [PATCH 2/3] ext4: fix mount parameters check for empty values Luis Henriques
2024-03-01 13:36 ` Christian Brauner [this message]
2024-03-01 15:47 ` Luis Henriques
2024-02-29 16:30 ` [PATCH 3/3] overlay: " Luis Henriques
2024-03-01 13:37 ` Christian Brauner
2024-03-01 13:12 ` [PATCH 0/3] fs_parser: handle parameters that can be empty and don't have a value Christian Brauner
2024-03-01 14:54 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301-spalten-impfschutz-4118b8fcf5b3@brauner \
--to=brauner@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=lhenriques@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).