From: Eric Sandeen <sandeen@sandeen.net>
To: Christian Brauner <brauner@kernel.org>,
Luis Henriques <lhenriques@suse.de>
Cc: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] fs_parser: handle parameters that can be empty and don't have a value
Date: Fri, 1 Mar 2024 08:54:37 -0600 [thread overview]
Message-ID: <8127e57f-51e8-437d-bf84-4836a315f696@sandeen.net> (raw)
In-Reply-To: <20240301-abheben-laborversuch-1a2c74c28643@brauner>
On 3/1/24 7:12 AM, Christian Brauner wrote:
>> Unfortunately, the two filesystems that use this flag (ext4 and overlayfs)
>> aren't prepared to have the parameter value set to NULL. Patches #2 and #3
>> fix this.
>
> Both ext4 and overlayfs define
>
> #define fsparam_string_empty(NAME, OPT) \
> __fsparam(fs_param_is_string, NAME, OPT, fs_param_can_be_empty, NULL)
>
> Please add that to include/linux/fs_parser.h so that it can be used by both.
The f2fs conversion will also need this, so yes, it'd be nice to hoist it out
of ext4 and overlayfs.
-Eric
prev parent reply other threads:[~2024-03-01 14:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 16:30 [PATCH 0/3] fs_parser: handle parameters that can be empty and don't have a value Luis Henriques
2024-02-29 16:30 ` [PATCH 1/3] " Luis Henriques
2024-03-01 13:31 ` Christian Brauner
2024-03-01 15:45 ` Luis Henriques
2024-03-02 11:46 ` Christian Brauner
2024-03-02 17:56 ` Christian Brauner
2024-03-03 21:31 ` Luis Henriques
2024-03-04 9:04 ` Christian Brauner
2024-03-03 21:17 ` Luis Henriques
2024-03-07 15:13 ` Jan Kara
2024-03-08 9:53 ` Christian Brauner
2024-03-08 10:12 ` Luis Henriques
2024-03-08 23:09 ` Jan Kara
2024-03-11 10:26 ` Luis Henriques
2024-03-11 16:01 ` Jan Kara
2024-02-29 16:30 ` [PATCH 2/3] ext4: fix mount parameters check for empty values Luis Henriques
2024-03-01 13:36 ` Christian Brauner
2024-03-01 15:47 ` Luis Henriques
2024-02-29 16:30 ` [PATCH 3/3] overlay: " Luis Henriques
2024-03-01 13:37 ` Christian Brauner
2024-03-01 13:12 ` [PATCH 0/3] fs_parser: handle parameters that can be empty and don't have a value Christian Brauner
2024-03-01 14:54 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8127e57f-51e8-437d-bf84-4836a315f696@sandeen.net \
--to=sandeen@sandeen.net \
--cc=adilger.kernel@dilger.ca \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=lhenriques@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).