* [PATCH v4 32/66] selftests/mount_setattr: Drop define _GNU_SOURCE
[not found] <20240510000842.410729-1-edliaw@google.com>
@ 2024-05-10 0:06 ` Edward Liaw
2024-05-10 0:07 ` [PATCH v4 45/66] selftests/proc: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 46/66] selftests/proc: Drop duplicate -D_GNU_SOURCE Edward Liaw
2 siblings, 0 replies; 3+ messages in thread
From: Edward Liaw @ 2024-05-10 0:06 UTC (permalink / raw)
To: shuah, Mickaël Salaün, Günther Noack,
Christian Brauner, Richard Cochran, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexei Starovoitov, Daniel Borkmann,
David S. Miller, Jakub Kicinski, Jesper Dangaard Brouer,
John Fastabend, Seth Forshee
Cc: linux-kernel, linux-kselftest, kernel-team, Edward Liaw,
linux-security-module, netdev, linux-riscv, bpf, John Hubbard,
Muhammad Usama Anjum, linux-fsdevel
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Edward Liaw <edliaw@google.com>
---
tools/testing/selftests/mount_setattr/mount_setattr_test.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/mount_setattr/mount_setattr_test.c b/tools/testing/selftests/mount_setattr/mount_setattr_test.c
index c6a8c732b802..d894417134b6 100644
--- a/tools/testing/selftests/mount_setattr/mount_setattr_test.c
+++ b/tools/testing/selftests/mount_setattr/mount_setattr_test.c
@@ -1,5 +1,4 @@
// SPDX-License-Identifier: GPL-2.0
-#define _GNU_SOURCE
#include <sched.h>
#include <stdio.h>
#include <errno.h>
--
2.45.0.118.g7fe29c98d7-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v4 45/66] selftests/proc: Drop define _GNU_SOURCE
[not found] <20240510000842.410729-1-edliaw@google.com>
2024-05-10 0:06 ` [PATCH v4 32/66] selftests/mount_setattr: Drop define _GNU_SOURCE Edward Liaw
@ 2024-05-10 0:07 ` Edward Liaw
2024-05-10 0:07 ` [PATCH v4 46/66] selftests/proc: Drop duplicate -D_GNU_SOURCE Edward Liaw
2 siblings, 0 replies; 3+ messages in thread
From: Edward Liaw @ 2024-05-10 0:07 UTC (permalink / raw)
To: shuah, Mickaël Salaün, Günther Noack,
Christian Brauner, Richard Cochran, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexei Starovoitov, Daniel Borkmann,
David S. Miller, Jakub Kicinski, Jesper Dangaard Brouer,
John Fastabend
Cc: linux-kernel, linux-kselftest, kernel-team, Edward Liaw,
linux-security-module, netdev, linux-riscv, bpf, linux-fsdevel
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw <edliaw@google.com>
---
tools/testing/selftests/proc/proc-empty-vm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/proc/proc-empty-vm.c b/tools/testing/selftests/proc/proc-empty-vm.c
index 56198d4ca2bf..f92a8dce58cf 100644
--- a/tools/testing/selftests/proc/proc-empty-vm.c
+++ b/tools/testing/selftests/proc/proc-empty-vm.c
@@ -23,9 +23,6 @@
* /proc/${pid}/smaps
* /proc/${pid}/smaps_rollup
*/
-#undef _GNU_SOURCE
-#define _GNU_SOURCE
-
#undef NDEBUG
#include <assert.h>
#include <errno.h>
--
2.45.0.118.g7fe29c98d7-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v4 46/66] selftests/proc: Drop duplicate -D_GNU_SOURCE
[not found] <20240510000842.410729-1-edliaw@google.com>
2024-05-10 0:06 ` [PATCH v4 32/66] selftests/mount_setattr: Drop define _GNU_SOURCE Edward Liaw
2024-05-10 0:07 ` [PATCH v4 45/66] selftests/proc: " Edward Liaw
@ 2024-05-10 0:07 ` Edward Liaw
2 siblings, 0 replies; 3+ messages in thread
From: Edward Liaw @ 2024-05-10 0:07 UTC (permalink / raw)
To: shuah, Mickaël Salaün, Günther Noack,
Christian Brauner, Richard Cochran, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexei Starovoitov, Daniel Borkmann,
David S. Miller, Jakub Kicinski, Jesper Dangaard Brouer,
John Fastabend
Cc: linux-kernel, linux-kselftest, kernel-team, Edward Liaw,
linux-security-module, netdev, linux-riscv, bpf, linux-fsdevel
-D_GNU_SOURCE can be de-duplicated here, as it is added by lib.mk.
Signed-off-by: Edward Liaw <edliaw@google.com>
---
tools/testing/selftests/proc/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/proc/Makefile b/tools/testing/selftests/proc/Makefile
index cd95369254c0..25c34cc9238e 100644
--- a/tools/testing/selftests/proc/Makefile
+++ b/tools/testing/selftests/proc/Makefile
@@ -1,6 +1,5 @@
# SPDX-License-Identifier: GPL-2.0-only
CFLAGS += -Wall -O2 -Wno-unused-function
-CFLAGS += -D_GNU_SOURCE
LDFLAGS += -pthread
TEST_GEN_PROGS :=
--
2.45.0.118.g7fe29c98d7-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-10 0:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20240510000842.410729-1-edliaw@google.com>
2024-05-10 0:06 ` [PATCH v4 32/66] selftests/mount_setattr: Drop define _GNU_SOURCE Edward Liaw
2024-05-10 0:07 ` [PATCH v4 45/66] selftests/proc: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 46/66] selftests/proc: Drop duplicate -D_GNU_SOURCE Edward Liaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).