From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org, clm@fb.com, josef@toxicpanda.com,
dsterba@suse.com, linux-fsdevel@vger.kernel.org,
kernel@gpiccoli.net, kernel-dev@igalia.com,
anand.jain@oracle.com, david@fromorbit.com, kreijack@libero.it,
johns@valvesoftware.com, ludovico.denittis@collabora.com,
quwenruo.btrfs@gmx.com, wqu@suse.com, vivek@collabora.com
Subject: Re: [PATCH V3 2/2] btrfs: Introduce the single-dev feature
Date: Tue, 5 Sep 2023 17:23:48 -0300 [thread overview]
Message-ID: <5a9ca846-e72b-3ee1-f163-dd9765b3b62e@igalia.com> (raw)
In-Reply-To: <20230905165041.GF14420@twin.jikos.cz>
On 05/09/2023 13:50, David Sterba wrote:
> [...]
> I'd like to pick this as a feature for 6.7, it's extending code we
> already have for metadata_uuid so this is a low risk feature. The only
> problem I see for now is the name, using the word 'single'.
>
> We have single as a block group profile name and a filesystem can exist
> on a single device too, this is would be confusing when referring to it.
> Single-dev can be a working name but for a final release we should
> really try to pick something more unique. I don't have a suggestion for
> now.
>
> The plan for now is that I'll add the patch to a topic branch and add it
> to for-next so it could be tested but there might be some updates still
> needed. Either as changes to this patch or as separate patches, that
> depends.
>
Hi David, thanks for your feedback! I agree with you that this name is a
bit confusing, we can easily change that! How about virtual-fsid?
I confess I'm not the best (by far!) to name stuff, so I'll be glad to
follow a suggestion from anyone here heheh
I also agree we could have this merged in your -next tree, and once a
new (good) name is proposed, I can re-submit with that and you'd replace
the patch in your tree, if that makes sense to you. Of course an extra
patch changing the name is also valid, if it's your preference.
Cheers,
Guilherme
next prev parent reply other threads:[~2023-09-05 20:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 0:12 [PATCH V3 0/2] Supporting same fsid mounting through the single-dev compat_ro feature Guilherme G. Piccoli
2023-08-31 0:12 ` [PATCH V3 1/2] btrfs-progs: Add the single-dev feature (to both mkfs/tune) Guilherme G. Piccoli
2023-09-12 9:27 ` Anand Jain
2023-09-13 23:00 ` Guilherme G. Piccoli
2023-09-19 5:15 ` Anand Jain
2023-08-31 0:12 ` [PATCH V3 2/2] btrfs: Introduce the single-dev feature Guilherme G. Piccoli
2023-09-05 16:50 ` David Sterba
2023-09-05 20:23 ` Guilherme G. Piccoli [this message]
2023-09-06 9:49 ` Anand Jain
2023-09-07 13:55 ` David Sterba
2023-09-07 15:07 ` Guilherme G. Piccoli
2023-09-07 16:01 ` Anand Jain
2023-09-07 13:56 ` Guilherme G. Piccoli
2023-09-06 16:14 ` Anand Jain
2023-09-07 15:06 ` Guilherme G. Piccoli
2023-09-11 18:28 ` David Sterba
2023-09-11 18:53 ` Guilherme G. Piccoli
2023-09-12 9:20 ` Anand Jain
2023-09-12 21:26 ` Guilherme G. Piccoli
2023-09-13 0:39 ` Anand Jain
2023-09-13 13:15 ` Guilherme G. Piccoli
2023-09-13 17:32 ` David Sterba
2023-09-13 17:58 ` Guilherme G. Piccoli
2023-09-13 17:24 ` David Sterba
2023-09-13 17:56 ` Guilherme G. Piccoli
2023-09-04 6:36 ` [PATCH V3 0/2] Supporting same fsid mounting through the single-dev compat_ro feature Anand Jain
2023-09-05 1:29 ` Guilherme G. Piccoli
2023-09-05 16:43 ` David Sterba
2023-09-06 14:19 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a9ca846-e72b-3ee1-f163-dd9765b3b62e@igalia.com \
--to=gpiccoli@igalia.com \
--cc=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=david@fromorbit.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=johns@valvesoftware.com \
--cc=josef@toxicpanda.com \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=kreijack@libero.it \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ludovico.denittis@collabora.com \
--cc=quwenruo.btrfs@gmx.com \
--cc=vivek@collabora.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).