From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Anand Jain <anand.jain@oracle.com>
Cc: clm@fb.com, linux-btrfs@vger.kernel.org, josef@toxicpanda.com,
dsterba@suse.com, linux-fsdevel@vger.kernel.org,
kernel@gpiccoli.net, kernel-dev@igalia.com, david@fromorbit.com,
kreijack@libero.it, johns@valvesoftware.com,
ludovico.denittis@collabora.com, quwenruo.btrfs@gmx.com,
wqu@suse.com, vivek@collabora.com
Subject: Re: [PATCH V3 1/2] btrfs-progs: Add the single-dev feature (to both mkfs/tune)
Date: Wed, 13 Sep 2023 20:00:01 -0300 [thread overview]
Message-ID: <8b629a31-9ee0-80db-0ef9-ade00a31255a@igalia.com> (raw)
In-Reply-To: <9a679809-6e59-d0e2-3dd1-3287a7af5349@oracle.com>
On 12/09/2023 06:27, Anand Jain wrote:
>
> We may need to fix the command 'btrfs filesystem show' aswell.
> Could you test having more than one single-devices with
> the same fsid and running 'btrfs filesystem show' to ensure
> it can still display all the devices?
>
> Thx.
> Anand
>
Hi Anand, thanks for noticing that. I've made this test (with the
patches V4), the result:
$ lsblk | grep nvme
nvme0n1 259:0 0 1G 0 disk
└─nvme0n1p1 259:1 0 1022M 0 part /mnt
nvme1n1 259:2 0 1G 0 disk
└─nvme1n1p1 259:3 0 1022M 0 part /mnt2
$ dmesg | grep TEMP
[ 802.818873] BTRFS info: random fsid
(c80a52e3-8f16-4095-bdc2-cc24bd01cf7d) set for TEMP_FSID device
/dev/nvme0n1p1 (real fsid 94b67f81-b51f-479e-9f44-0d33d5cec2d4)
[ 805.761222] BTRFS info: random fsid
(5a0a6628-8cd0-4353-8daf-b01ca254c10d) set for TEMP_FSID device
/dev/nvme1n1p1 (real fsid 94b67f81-b51f-479e-9f44-0d33d5cec2d4)
$ btrfs filesystem show
Label: none uuid: c80a52e3-8f16-4095-bdc2-cc24bd01cf7d
Total devices 1 FS bytes used 144.00KiB
devid 1 size 1022.00MiB used 126.12MiB path /dev/nvme0n1p1
Label: none uuid: 5a0a6628-8cd0-4353-8daf-b01ca254c10d
Total devices 1 FS bytes used 144.00KiB
devid 1 size 1022.00MiB used 126.12MiB path /dev/nvme1n1p1
Label: none uuid: 94b67f81-b51f-479e-9f44-0d33d5cec2d4
Total devices 1 FS bytes used 144.00KiB
devid 1 size 1022.00MiB used 126.12MiB path /dev/nvme1n1p1
It seems to me it's correct "enough" right? It shows the mounted
filesystems according to the temporary fsid.
Also, I've noticed that the real fsid is omitted for device nvme0n1p1,
i.e., the command de-duplicates devices with the same fsid - tested here
without the TEMP_FSID feature and it behaves the same way.
In case you think we could improve such output, I appreciate
suggestions, and I'd be glad if that could be considered an improvement
(i.e., not blocking the patch merge on misc-next) since I might not have
the time to work on this for some weeks...
Cheers,
Guilherme
next prev parent reply other threads:[~2023-09-13 23:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 0:12 [PATCH V3 0/2] Supporting same fsid mounting through the single-dev compat_ro feature Guilherme G. Piccoli
2023-08-31 0:12 ` [PATCH V3 1/2] btrfs-progs: Add the single-dev feature (to both mkfs/tune) Guilherme G. Piccoli
2023-09-12 9:27 ` Anand Jain
2023-09-13 23:00 ` Guilherme G. Piccoli [this message]
2023-09-19 5:15 ` Anand Jain
2023-08-31 0:12 ` [PATCH V3 2/2] btrfs: Introduce the single-dev feature Guilherme G. Piccoli
2023-09-05 16:50 ` David Sterba
2023-09-05 20:23 ` Guilherme G. Piccoli
2023-09-06 9:49 ` Anand Jain
2023-09-07 13:55 ` David Sterba
2023-09-07 15:07 ` Guilherme G. Piccoli
2023-09-07 16:01 ` Anand Jain
2023-09-07 13:56 ` Guilherme G. Piccoli
2023-09-06 16:14 ` Anand Jain
2023-09-07 15:06 ` Guilherme G. Piccoli
2023-09-11 18:28 ` David Sterba
2023-09-11 18:53 ` Guilherme G. Piccoli
2023-09-12 9:20 ` Anand Jain
2023-09-12 21:26 ` Guilherme G. Piccoli
2023-09-13 0:39 ` Anand Jain
2023-09-13 13:15 ` Guilherme G. Piccoli
2023-09-13 17:32 ` David Sterba
2023-09-13 17:58 ` Guilherme G. Piccoli
2023-09-13 17:24 ` David Sterba
2023-09-13 17:56 ` Guilherme G. Piccoli
2023-09-04 6:36 ` [PATCH V3 0/2] Supporting same fsid mounting through the single-dev compat_ro feature Anand Jain
2023-09-05 1:29 ` Guilherme G. Piccoli
2023-09-05 16:43 ` David Sterba
2023-09-06 14:19 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b629a31-9ee0-80db-0ef9-ade00a31255a@igalia.com \
--to=gpiccoli@igalia.com \
--cc=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=david@fromorbit.com \
--cc=dsterba@suse.com \
--cc=johns@valvesoftware.com \
--cc=josef@toxicpanda.com \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=kreijack@libero.it \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ludovico.denittis@collabora.com \
--cc=quwenruo.btrfs@gmx.com \
--cc=vivek@collabora.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).