* [RFC][PATCH] freevxfs_lookup(): use d_splice_alias()
@ 2018-05-13 21:12 Al Viro
0 siblings, 0 replies; only message in thread
From: Al Viro @ 2018-05-13 21:12 UTC (permalink / raw)
To: linux-fsdevel; +Cc: hch, Hellwig, Christoph
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
fs/freevxfs/vxfs_lookup.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/fs/freevxfs/vxfs_lookup.c b/fs/freevxfs/vxfs_lookup.c
index ce4785fd81c6..a51425634f65 100644
--- a/fs/freevxfs/vxfs_lookup.c
+++ b/fs/freevxfs/vxfs_lookup.c
@@ -193,13 +193,9 @@ vxfs_lookup(struct inode *dip, struct dentry *dp, unsigned int flags)
return ERR_PTR(-ENAMETOOLONG);
ino = vxfs_inode_by_name(dip, dp);
- if (ino) {
+ if (ino)
ip = vxfs_iget(dip->i_sb, ino);
- if (IS_ERR(ip))
- return ERR_CAST(ip);
- }
- d_add(dp, ip);
- return NULL;
+ return d_splice_alias(ip, dp);
}
/**
--
2.11.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-05-13 21:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-13 21:12 [RFC][PATCH] freevxfs_lookup(): use d_splice_alias() Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).