* [PATCH v1 0/2] exfat: get file size from DataLength
@ 2023-06-15 3:29 Yuezhang.Mo
2023-06-22 6:47 ` Namjae Jeon
0 siblings, 1 reply; 5+ messages in thread
From: Yuezhang.Mo @ 2023-06-15 3:29 UTC (permalink / raw)
To: linkinjeon, sj1557.seo; +Cc: linux-fsdevel, Andy.Wu, Wataru.Aoyama
From the exFAT specification, the file size should get from 'DataLength'
of Stream Extension Directory Entry, not 'ValidDataLength'.
Without this patch set, 'DataLength' is always same with 'ValidDataLength'
and get file size from 'ValidDataLength'. But if the file is created by other
exFAT implementation and 'DataLength' is different from 'ValidDataLength',
this exFAT implementation will not be compatible.
Yuezhang Mo (2):
exfat: change to get file size from DataLength
exfat: do not zeroed the extended part
fs/exfat/exfat_fs.h | 2 +
fs/exfat/file.c | 212 +++++++++++++++++++++++++++++++++++++++++++-
fs/exfat/inode.c | 108 +++++++++++++++++++---
fs/exfat/namei.c | 7 +-
4 files changed, 310 insertions(+), 19 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 0/2] exfat: get file size from DataLength
2023-06-15 3:29 [PATCH v1 0/2] exfat: get file size from DataLength Yuezhang.Mo
@ 2023-06-22 6:47 ` Namjae Jeon
2023-06-25 6:29 ` Yuezhang.Mo
0 siblings, 1 reply; 5+ messages in thread
From: Namjae Jeon @ 2023-06-22 6:47 UTC (permalink / raw)
To: Yuezhang.Mo; +Cc: sj1557.seo, linux-fsdevel, Andy.Wu, Wataru.Aoyama
2023-06-15 12:29 GMT+09:00, Yuezhang.Mo@sony.com <Yuezhang.Mo@sony.com>:
> From the exFAT specification, the file size should get from 'DataLength'
> of Stream Extension Directory Entry, not 'ValidDataLength'.
>
> Without this patch set, 'DataLength' is always same with 'ValidDataLength'
> and get file size from 'ValidDataLength'. But if the file is created by
> other
> exFAT implementation and 'DataLength' is different from 'ValidDataLength',
> this exFAT implementation will not be compatible.
>
> Yuezhang Mo (2):
> exfat: change to get file size from DataLength
> exfat: do not zeroed the extended part
Hi Yuezhang,
First, Thank you so much for your work.
Have you ever run xfstests against exfat included this changes ?
Thanks!
>
> fs/exfat/exfat_fs.h | 2 +
> fs/exfat/file.c | 212 +++++++++++++++++++++++++++++++++++++++++++-
> fs/exfat/inode.c | 108 +++++++++++++++++++---
> fs/exfat/namei.c | 7 +-
> 4 files changed, 310 insertions(+), 19 deletions(-)
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v1 0/2] exfat: get file size from DataLength
2023-06-22 6:47 ` Namjae Jeon
@ 2023-06-25 6:29 ` Yuezhang.Mo
2023-06-26 8:45 ` Yuezhang.Mo
0 siblings, 1 reply; 5+ messages in thread
From: Yuezhang.Mo @ 2023-06-25 6:29 UTC (permalink / raw)
To: Namjae Jeon; +Cc: sj1557.seo, linux-fsdevel, Andy.Wu, Wataru.Aoyama
> From: Namjae Jeon <linkinjeon@kernel.org>
> Sent: Thursday, June 22, 2023 2:48 PM
> 2023-06-15 12:29 GMT+09:00, Yuezhang.Mo@sony.com
> > Yuezhang Mo (2):
> > exfat: change to get file size from DataLength
> > exfat: do not zeroed the extended part
> Hi Yuezhang,
>
> First, Thank you so much for your work.
> Have you ever run xfstests against exfat included this changes ?
Yes, all generic/??? tests of xfstests pass, except generic /251.
Are there any tests that fail in your environment?
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v1 0/2] exfat: get file size from DataLength
2023-06-25 6:29 ` Yuezhang.Mo
@ 2023-06-26 8:45 ` Yuezhang.Mo
2023-06-26 12:37 ` Namjae Jeon
0 siblings, 1 reply; 5+ messages in thread
From: Yuezhang.Mo @ 2023-06-26 8:45 UTC (permalink / raw)
To: Namjae Jeon; +Cc: sj1557.seo, linux-fsdevel, Andy.Wu, Wataru.Aoyama
> From: Mo, Yuezhang
> Sent: Sunday, June 25, 2023 2:29 PM
> > From: Namjae Jeon <linkinjeon@kernel.org>
> > First, Thank you so much for your work.
> > Have you ever run xfstests against exfat included this changes ?
>
> Yes, all generic/??? tests of xfstests pass, except generic/251.
> Are there any tests that fail in your environment?
I run xfstests iteratively and found generic/465 will sometimes fail, the probability of failure is 1/20.
I will investigate it and update these patches.
PS: generic/251 also fails without these patches, the reason is `cp -a` fails.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 0/2] exfat: get file size from DataLength
2023-06-26 8:45 ` Yuezhang.Mo
@ 2023-06-26 12:37 ` Namjae Jeon
0 siblings, 0 replies; 5+ messages in thread
From: Namjae Jeon @ 2023-06-26 12:37 UTC (permalink / raw)
To: Yuezhang.Mo; +Cc: sj1557.seo, linux-fsdevel, Andy.Wu, Wataru.Aoyama
2023-06-26 17:45 GMT+09:00, Yuezhang.Mo@sony.com <Yuezhang.Mo@sony.com>:
>> From: Mo, Yuezhang
>> Sent: Sunday, June 25, 2023 2:29 PM
>> > From: Namjae Jeon <linkinjeon@kernel.org>
>> > First, Thank you so much for your work.
>> > Have you ever run xfstests against exfat included this changes ?
>>
>> Yes, all generic/??? tests of xfstests pass, except generic/251.
>> Are there any tests that fail in your environment?
>
> I run xfstests iteratively and found generic/465 will sometimes fail, the
> probability of failure is 1/20.
> I will investigate it and update these patches.
Okay.
>
> PS: generic/251 also fails without these patches, the reason is `cp -a`
> fails.
I will check it.
Thanks!
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-26 12:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-15 3:29 [PATCH v1 0/2] exfat: get file size from DataLength Yuezhang.Mo
2023-06-22 6:47 ` Namjae Jeon
2023-06-25 6:29 ` Yuezhang.Mo
2023-06-26 8:45 ` Yuezhang.Mo
2023-06-26 12:37 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).