From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: "Andrei Vagin" <avagin@gmail.com>,
"Danylo Mocherniuk" <mdanylo@google.com>,
"Alex Sierra" <alex.sierra@amd.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Axel Rasmussen" <axelrasmussen@google.com>,
"Christian Brauner" <brauner@kernel.org>,
"Cyrill Gorcunov" <gorcunov@gmail.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"David Hildenbrand" <david@redhat.com>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Michał Mirosław" <emmir@google.com>,
"Mike Rapoport" <rppt@kernel.org>,
"Nadav Amit" <namit@vmware.com>,
"Pasha Tatashin" <pasha.tatashin@soleen.com>,
"Paul Gofman" <pgofman@codeweavers.com>,
"Peter Xu" <peterx@redhat.com>, "Shuah Khan" <shuah@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Yang Shi" <shy828301@gmail.com>,
"Yun Zhou" <yun.zhou@windriver.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
kernel@collabora.com
Subject: Re: fs/proc/task_mmu: Implement IOCTL for efficient page table scanning
Date: Fri, 21 Jul 2023 13:29:20 +0200 [thread overview]
Message-ID: <ZLpsEGZkeQECO08M@qmqm.qmqm.pl> (raw)
In-Reply-To: <7eedf953-7cf6-c342-8fa8-b7626d69ab63@collabora.com>
On Fri, Jul 21, 2023 at 03:48:22PM +0500, Muhammad Usama Anjum wrote:
> On 7/21/23 12:28 AM, Michał Mirosław wrote:
> > This is a massaged version of patch by Muhammad Usama Anjum [1]
> > to illustrate my review comments and hopefully push the implementation
> > efforts closer to conclusion. The changes are:
> Thank you so much for this effort. I also want to reach conclusion. I'll
> agree with all the changes which don't affect me. But some requirements
> aren't being fulfilled with this current design.
[...]
> #define PAGE_IS_WPASYNC (1 << 0)
> #define PAGE_IS_WRITTEN (1 << 1)
> You have another new flag PAGE_IS_WPASYNC. But there is no application of
> PAGE_IS_WPASYNC. We must not add a flag which don't have any user.
BTW, I'm not sure I got the PAGE_IS_WPASYNC naming right - this is to
designate pages that can be write-protected (are UFFD-registered I believe).
Best Regards
Michał Mirosław
next prev parent reply other threads:[~2023-07-21 11:29 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 10:14 [PATCH v25 0/5] Implement IOCTL to get and optionally clear info about PTEs Muhammad Usama Anjum
2023-07-13 10:14 ` [PATCH v25 1/5] userfaultfd: UFFD_FEATURE_WP_ASYNC Muhammad Usama Anjum
2023-07-13 10:14 ` [PATCH v25 2/5] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs Muhammad Usama Anjum
2023-07-17 17:26 ` Andrei Vagin
2023-07-18 8:18 ` Muhammad Usama Anjum
2023-07-18 16:08 ` Andrei Vagin
2023-07-18 16:27 ` Muhammad Usama Anjum
2023-07-13 10:14 ` [PATCH v25 3/5] tools headers UAPI: Update linux/fs.h with the kernel sources Muhammad Usama Anjum
2023-07-13 10:14 ` [PATCH v25 4/5] mm/pagemap: add documentation of PAGEMAP_SCAN IOCTL Muhammad Usama Anjum
2023-07-13 10:14 ` [PATCH v25 5/5] selftests: mm: add pagemap ioctl tests Muhammad Usama Anjum
[not found] ` <a0b5c6776b2ed91f78a7575649f8b100e58bd3a9.1689881078.git.mirq-linux@rere.qmqm.pl>
2023-07-20 19:50 ` fs/proc/task_mmu: Implement IOCTL for efficient page table scanning Michał Mirosław
2023-07-20 21:12 ` kernel test robot
2023-07-21 2:56 ` kernel test robot
2023-07-21 4:27 ` Muhammad Usama Anjum
2023-07-21 14:49 ` Andrei Vagin
2023-07-21 5:43 ` kernel test robot
2023-07-21 7:18 ` kernel test robot
2023-07-21 10:48 ` Muhammad Usama Anjum
2023-07-21 11:23 ` Michał Mirosław
2023-07-21 17:50 ` Muhammad Usama Anjum
2023-07-22 0:22 ` Michał Mirosław
2023-07-22 0:24 ` [v2] " Michał Mirosław
2023-07-22 13:55 ` kernel test robot
2023-07-22 14:05 ` kernel test robot
2023-07-24 14:04 ` Muhammad Usama Anjum
2023-07-24 14:38 ` Michał Mirosław
2023-07-24 15:21 ` Muhammad Usama Anjum
2023-07-24 16:10 ` Michał Mirosław
2023-07-25 7:23 ` Muhammad Usama Anjum
2023-07-25 9:09 ` Muhammad Usama Anjum
2023-07-25 9:11 ` [v3] " Muhammad Usama Anjum
2023-07-25 18:05 ` Michał Mirosław
2023-07-26 8:34 ` Muhammad Usama Anjum
2023-07-26 21:10 ` Michał Mirosław
2023-07-26 23:06 ` Paul Gofman
2023-07-27 11:18 ` Michał Mirosław
2023-07-27 11:21 ` Michał Mirosław
2023-07-27 17:15 ` Paul Gofman
2023-07-27 8:03 ` Muhammad Usama Anjum
2023-07-27 11:26 ` Michał Mirosław
2023-07-27 11:31 ` Muhammad Usama Anjum
2023-07-21 11:29 ` Michał Mirosław [this message]
2023-07-21 17:51 ` Muhammad Usama Anjum
2023-08-26 13:07 ` kernel test robot
2023-07-18 16:05 ` [PATCH v25 0/5] Implement IOCTL to get and optionally clear info about PTEs Rogerio Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLpsEGZkeQECO08M@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=alex.sierra@amd.com \
--cc=avagin@gmail.com \
--cc=axelrasmussen@google.com \
--cc=brauner@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=emmir@google.com \
--cc=gorcunov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=kernel@collabora.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mdanylo@google.com \
--cc=namit@vmware.com \
--cc=pasha.tatashin@soleen.com \
--cc=peterx@redhat.com \
--cc=pgofman@codeweavers.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=shy828301@gmail.com \
--cc=surenb@google.com \
--cc=usama.anjum@collabora.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=yun.zhou@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).