* [PATCH 04/62] gpio: gpio-104-idio-16: Use new GPIO_LINE_DIRECTION
[not found] <cover.1572945633.git.matti.vaittinen@fi.rohmeurope.com>
@ 2019-11-05 10:11 ` Matti Vaittinen
0 siblings, 0 replies; only message in thread
From: Matti Vaittinen @ 2019-11-05 10:11 UTC (permalink / raw)
To: matti.vaittinen, mazziesaccount
Cc: William Breathitt Gray, Linus Walleij, Bartosz Golaszewski,
linux-gpio, linux-kernel
It's hard for occasional GPIO code reader/writer to know if values 0/1
equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and
GPIO_LINE_DIRECTION_OUT to help them out.
Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---
drivers/gpio/gpio-104-idio-16.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-104-idio-16.c b/drivers/gpio/gpio-104-idio-16.c
index 8d2f51cd9d91..5752d9dab148 100644
--- a/drivers/gpio/gpio-104-idio-16.c
+++ b/drivers/gpio/gpio-104-idio-16.c
@@ -51,9 +51,9 @@ struct idio_16_gpio {
static int idio_16_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
{
if (offset > 15)
- return 1;
+ return GPIO_LINE_DIRECTION_IN;
- return 0;
+ return GPIO_LINE_DIRECTION_OUT;
}
static int idio_16_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
--
2.21.0
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-11-05 10:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1572945633.git.matti.vaittinen@fi.rohmeurope.com>
2019-11-05 10:11 ` [PATCH 04/62] gpio: gpio-104-idio-16: Use new GPIO_LINE_DIRECTION Matti Vaittinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).