* Re: [PATCH 1/2] pinctrl: qcom-ssbi: add support for PM8901
2024-04-15 14:17 [PATCH 1/2] pinctrl: qcom-ssbi: add support for PM8901 Herman van Hazendonk
@ 2024-04-17 7:05 ` Dmitry Baryshkov
2024-04-17 7:35 ` [PATCH v2 1/2] dt-bindings: pinctrl: qcom,pmic-mpp: " Herman van Hazendonk
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2024-04-17 7:05 UTC (permalink / raw)
To: Herman van Hazendonk
Cc: andersson, benwolsieffer, chris.chapuis, Konrad Dybcio,
Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, linux-gpio, devicetree, linux-kernel
On Mon, 15 Apr 2024 at 17:28, Herman van Hazendonk
<github.com@herrie.org> wrote:
>
> The PM8901 is used alongside the APQ8060/MSM8660 on the APQ8060 Dragonboard
> and HP TouchPad. It works the same as all others, so just add the
> compatible string for this variant.
>
> Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 1 +
> 1 file changed, 1 insertion(+)
Subject should be "dt-bindings: pinctrl: qcom,pmic-mpp: ..... "
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> index fe717d8d4798..43146709e204 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
> @@ -35,6 +35,7 @@ properties:
> - qcom,pm8038-mpp
> - qcom,pm8058-mpp
> - qcom,pm8821-mpp
> + - qcom,pm8901-mpp
> - qcom,pm8917-mpp
> - qcom,pm8921-mpp
> - const: qcom,ssbi-mpp
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2 1/2] dt-bindings: pinctrl: qcom,pmic-mpp: add support for PM8901
2024-04-15 14:17 [PATCH 1/2] pinctrl: qcom-ssbi: add support for PM8901 Herman van Hazendonk
2024-04-17 7:05 ` Dmitry Baryshkov
@ 2024-04-17 7:35 ` Herman van Hazendonk
2024-04-17 19:03 ` Rob Herring
2024-04-17 9:26 ` [PATCH 1/2] pinctrl: qcom-ssbi: " Linus Walleij
2024-04-17 14:11 ` Krzysztof Kozlowski
3 siblings, 1 reply; 6+ messages in thread
From: Herman van Hazendonk @ 2024-04-17 7:35 UTC (permalink / raw)
To: github.com
Cc: andersson, benwolsieffer, chris.chapuis, conor+dt, devicetree,
konrad.dybcio, krzk+dt, linus.walleij, linux-arm-msm, linux-gpio,
linux-kernel, robh
The PM8901 is used alongside the APQ8060/MSM8660 on the APQ8060 Dragonboard
and HP TouchPad. It works the same as all others, so just add the
compatible string for this variant.
Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
index fe717d8d4798..43146709e204 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml
@@ -35,6 +35,7 @@ properties:
- qcom,pm8038-mpp
- qcom,pm8058-mpp
- qcom,pm8821-mpp
+ - qcom,pm8901-mpp
- qcom,pm8917-mpp
- qcom,pm8921-mpp
- const: qcom,ssbi-mpp
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom,pmic-mpp: add support for PM8901
2024-04-17 7:35 ` [PATCH v2 1/2] dt-bindings: pinctrl: qcom,pmic-mpp: " Herman van Hazendonk
@ 2024-04-17 19:03 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2024-04-17 19:03 UTC (permalink / raw)
To: Herman van Hazendonk
Cc: andersson, benwolsieffer, chris.chapuis, conor+dt, devicetree,
konrad.dybcio, krzk+dt, linus.walleij, linux-arm-msm, linux-gpio,
linux-kernel
On Wed, Apr 17, 2024 at 09:35:32AM +0200, Herman van Hazendonk wrote:
> The PM8901 is used alongside the APQ8060/MSM8660 on the APQ8060 Dragonboard
> and HP TouchPad. It works the same as all others, so just add the
> compatible string for this variant.
Please slow down the pace of your reposting giving people time to
respond. People work in different timezones, get busy with their own
stuff, travel to conferences, etc. As you see here, Linus fixed it up
and there was no need to even post a new version.
Also, don't send new versions as replies to the prior version. Start a
new thread.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] pinctrl: qcom-ssbi: add support for PM8901
2024-04-15 14:17 [PATCH 1/2] pinctrl: qcom-ssbi: add support for PM8901 Herman van Hazendonk
2024-04-17 7:05 ` Dmitry Baryshkov
2024-04-17 7:35 ` [PATCH v2 1/2] dt-bindings: pinctrl: qcom,pmic-mpp: " Herman van Hazendonk
@ 2024-04-17 9:26 ` Linus Walleij
2024-04-17 14:11 ` Krzysztof Kozlowski
3 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2024-04-17 9:26 UTC (permalink / raw)
To: Herman van Hazendonk
Cc: andersson, benwolsieffer, chris.chapuis, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
On Mon, Apr 15, 2024 at 4:17 PM Herman van Hazendonk
<github.com@herrie.org> wrote:
> The PM8901 is used alongside the APQ8060/MSM8660 on the APQ8060 Dragonboard
> and HP TouchPad. It works the same as all others, so just add the
> compatible string for this variant.
>
> Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
Patch applied, fixing subject.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] pinctrl: qcom-ssbi: add support for PM8901
2024-04-15 14:17 [PATCH 1/2] pinctrl: qcom-ssbi: add support for PM8901 Herman van Hazendonk
` (2 preceding siblings ...)
2024-04-17 9:26 ` [PATCH 1/2] pinctrl: qcom-ssbi: " Linus Walleij
@ 2024-04-17 14:11 ` Krzysztof Kozlowski
3 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-17 14:11 UTC (permalink / raw)
To: Herman van Hazendonk, andersson
Cc: benwolsieffer, chris.chapuis, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
On 15/04/2024 16:17, Herman van Hazendonk wrote:
> The PM8901 is used alongside the APQ8060/MSM8660 on the APQ8060 Dragonboard
> and HP TouchPad. It works the same as all others, so just add the
> compatible string for this variant.
>
> Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
> ---
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread