[PATCH] m68k: coldfire: Include the GPIO driver header

[PATCH] m68k: coldfire: Include the GPIO driver header

[Linus Walleij]

The Coldfire GPIO driver needs to explicitly incldue the
GPIO driver header since it is providing a driver.

Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Geert can you pick this up for m68k?
---
 arch/m68k/coldfire/gpio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c
index a83898426127..ca26de257871 100644
--- a/arch/m68k/coldfire/gpio.c
+++ b/arch/m68k/coldfire/gpio.c
@@ -9,6 +9,7 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/device.h>
+#include <linux/gpio/driver.h>
 
 #include <linux/io.h>
 #include <asm/coldfire.h>
-- 
2.21.0

Re: [PATCH] m68k: coldfire: Include the GPIO driver header

[Geert Uytterhoeven]

CC Greg (coldfire)

On Wed, Aug 21, 2019 at 9:09 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> The Coldfire GPIO driver needs to explicitly incldue the
> GPIO driver header since it is providing a driver.
>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Geert can you pick this up for m68k?
> ---
>  arch/m68k/coldfire/gpio.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c
> index a83898426127..ca26de257871 100644
> --- a/arch/m68k/coldfire/gpio.c
> +++ b/arch/m68k/coldfire/gpio.c
> @@ -9,6 +9,7 @@
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/device.h>
> +#include <linux/gpio/driver.h>
>
>  #include <linux/io.h>
>  #include <asm/coldfire.h>
> --
> 2.21.0

Re: [PATCH] m68k: coldfire: Include the GPIO driver header

[Greg Ungerer]

On 21/8/19 5:19 pm, Geert Uytterhoeven wrote:
> CC Greg (coldfire)

Thanks Geert.
I am happy to take it via the m68knommu tree if you prefer?

Regards
Greg



> On Wed, Aug 21, 2019 at 9:09 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>> The Coldfire GPIO driver needs to explicitly incldue the
>> GPIO driver header since it is providing a driver.
>>
>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> Geert can you pick this up for m68k?
>> ---
>>   arch/m68k/coldfire/gpio.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c
>> index a83898426127..ca26de257871 100644
>> --- a/arch/m68k/coldfire/gpio.c
>> +++ b/arch/m68k/coldfire/gpio.c
>> @@ -9,6 +9,7 @@
>>   #include <linux/module.h>
>>   #include <linux/init.h>
>>   #include <linux/device.h>
>> +#include <linux/gpio/driver.h>
>>
>>   #include <linux/io.h>
>>   #include <asm/coldfire.h>
>> --
>> 2.21.0
> 

Re: [PATCH] m68k: coldfire: Include the GPIO driver header

[Geert Uytterhoeven]

Hi Greg,

On Wed, Aug 21, 2019 at 2:22 PM Greg Ungerer <gerg@linux-m68k.org> wrote:
> On 21/8/19 5:19 pm, Geert Uytterhoeven wrote:
> > CC Greg (coldfire)
>
> Thanks Geert.
> I am happy to take it via the m68knommu tree if you prefer?

Sounds most logical to me.
Thanks!

> > On Wed, Aug 21, 2019 at 9:09 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> >> The Coldfire GPIO driver needs to explicitly incldue the
> >> GPIO driver header since it is providing a driver.
> >>
> >> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >> ---
> >> Geert can you pick this up for m68k?
> >> ---
> >>   arch/m68k/coldfire/gpio.c | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c
> >> index a83898426127..ca26de257871 100644
> >> --- a/arch/m68k/coldfire/gpio.c
> >> +++ b/arch/m68k/coldfire/gpio.c
> >> @@ -9,6 +9,7 @@
> >>   #include <linux/module.h>
> >>   #include <linux/init.h>
> >>   #include <linux/device.h>
> >> +#include <linux/gpio/driver.h>
> >>
> >>   #include <linux/io.h>
> >>   #include <asm/coldfire.h>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] m68k: coldfire: Include the GPIO driver header

[Greg Ungerer]

Hi Geert, Linus,

On 21/8/19 10:50 pm, Geert Uytterhoeven wrote:
> On Wed, Aug 21, 2019 at 2:22 PM Greg Ungerer <gerg@linux-m68k.org> wrote:
>> On 21/8/19 5:19 pm, Geert Uytterhoeven wrote:
>>> CC Greg (coldfire)
>>
>> Thanks Geert.
>> I am happy to take it via the m68knommu tree if you prefer?
> 
> Sounds most logical to me.
> Thanks!

Pushed to the for-next branch of the m68knommu git tree.

Regards
Greg



>>> On Wed, Aug 21, 2019 at 9:09 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>>>> The Coldfire GPIO driver needs to explicitly incldue the
>>>> GPIO driver header since it is providing a driver.
>>>>
>>>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>>> ---
>>>> Geert can you pick this up for m68k?
>>>> ---
>>>>    arch/m68k/coldfire/gpio.c | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c
>>>> index a83898426127..ca26de257871 100644
>>>> --- a/arch/m68k/coldfire/gpio.c
>>>> +++ b/arch/m68k/coldfire/gpio.c
>>>> @@ -9,6 +9,7 @@
>>>>    #include <linux/module.h>
>>>>    #include <linux/init.h>
>>>>    #include <linux/device.h>
>>>> +#include <linux/gpio/driver.h>
>>>>
>>>>    #include <linux/io.h>
>>>>    #include <asm/coldfire.h>
> 
> Gr{oetje,eeting}s,
> 
>                          Geert
>