[PATCH] pinctrl: qcom: make 'm_voc_groups' static

[PATCH] pinctrl: qcom: make 'm_voc_groups' static

[Ben Dooks (Codethink)]

The m_voc_groups is not declared outside of the
driver, so make it static to avoid the following
sparse wanrning:

drivers/pinctrl/qcom/pinctrl-msm8976.c:592:12: warning: symbol 'm_voc_groups' was not declared. Should it be static?

Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
---
 drivers/pinctrl/qcom/pinctrl-msm8976.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-msm8976.c b/drivers/pinctrl/qcom/pinctrl-msm8976.c
index e1259ce27396..183f0b2d9f8e 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm8976.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm8976.c
@@ -589,7 +589,7 @@ static const char * const blsp_uart5_groups[] = {
 static const char * const qdss_traceclk_a_groups[] = {
 	"gpio46",
 };
-const char * const m_voc_groups[] = {
+static const char * const m_voc_groups[] = {
 	"gpio123", "gpio124",
 };
 static const char * const blsp_i2c5_groups[] = {
-- 
2.24.0

Re: [PATCH] pinctrl: qcom: make 'm_voc_groups' static

[Bjorn Andersson]

On Wed 18 Dec 02:28 PST 2019, Ben Dooks (Codethink) wrote:

> The m_voc_groups is not declared outside of the
> driver, so make it static to avoid the following
> sparse wanrning:
> 
> drivers/pinctrl/qcom/pinctrl-msm8976.c:592:12: warning: symbol 'm_voc_groups' was not declared. Should it be static?
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> ---
>  drivers/pinctrl/qcom/pinctrl-msm8976.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm8976.c b/drivers/pinctrl/qcom/pinctrl-msm8976.c
> index e1259ce27396..183f0b2d9f8e 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm8976.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm8976.c
> @@ -589,7 +589,7 @@ static const char * const blsp_uart5_groups[] = {
>  static const char * const qdss_traceclk_a_groups[] = {
>  	"gpio46",
>  };
> -const char * const m_voc_groups[] = {
> +static const char * const m_voc_groups[] = {
>  	"gpio123", "gpio124",
>  };
>  static const char * const blsp_i2c5_groups[] = {
> -- 
> 2.24.0
> 

Re: [PATCH] pinctrl: qcom: make 'm_voc_groups' static

[Linus Walleij]

On Wed, Dec 18, 2019 at 11:30 AM Ben Dooks (Codethink)
<ben.dooks@codethink.co.uk> wrote:

> The m_voc_groups is not declared outside of the
> driver, so make it static to avoid the following
> sparse wanrning:
>
> drivers/pinctrl/qcom/pinctrl-msm8976.c:592:12: warning: symbol 'm_voc_groups' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>

Patch applied with Björn's ACK!

Yours,
Linus Walleij