linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] docs/pinctrl: fix compile errors in example code
@ 2019-07-05 14:30 Luca Ceresoli
  2019-07-28 22:20 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Luca Ceresoli @ 2019-07-05 14:30 UTC (permalink / raw)
  To: linux-gpio
  Cc: Luca Ceresoli, Linus Walleij, Jonathan Corbet, linux-doc, linux-kernel

The code in the example does not build for a few trivial errors: type
mismatch in callback, missing semicolon. Fix them to help newcomers using
the example as a starting point.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
 Documentation/driver-api/pinctl.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/driver-api/pinctl.rst b/Documentation/driver-api/pinctl.rst
index 2bb1bc484278..3d2deaf48841 100644
--- a/Documentation/driver-api/pinctl.rst
+++ b/Documentation/driver-api/pinctl.rst
@@ -638,8 +638,8 @@ group of pins would work something like this::
 	}
 
 	static int foo_get_group_pins(struct pinctrl_dev *pctldev, unsigned selector,
-				unsigned ** const pins,
-				unsigned * const num_pins)
+				const unsigned ** pins,
+				unsigned * num_pins)
 	{
 		*pins = (unsigned *) foo_groups[selector].pins;
 		*num_pins = foo_groups[selector].num_pins;
@@ -705,7 +705,7 @@ group of pins would work something like this::
 	{
 		u8 regbit = (1 << selector + group);
 
-		writeb((readb(MUX)|regbit), MUX)
+		writeb((readb(MUX)|regbit), MUX);
 		return 0;
 	}
 
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] docs/pinctrl: fix compile errors in example code
  2019-07-05 14:30 [PATCH] docs/pinctrl: fix compile errors in example code Luca Ceresoli
@ 2019-07-28 22:20 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2019-07-28 22:20 UTC (permalink / raw)
  To: Luca Ceresoli
  Cc: open list:GPIO SUBSYSTEM, Jonathan Corbet,
	Linux Doc Mailing List, linux-kernel

On Fri, Jul 5, 2019 at 4:30 PM Luca Ceresoli <luca@lucaceresoli.net> wrote:

> The code in the example does not build for a few trivial errors: type
> mismatch in callback, missing semicolon. Fix them to help newcomers using
> the example as a starting point.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-28 22:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-05 14:30 [PATCH] docs/pinctrl: fix compile errors in example code Luca Ceresoli
2019-07-28 22:20 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).