From: Philipp Stanner <pstanner@redhat.com>
To: Kees Cook <keescook@chromium.org>,
Andy Shevchenko <andy@kernel.org>,
Eric Biederman <ebiederm@xmission.com>,
Christian Brauner <brauner@kernel.org>,
David Disseldorp <ddiss@suse.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Siddh Raman Pant <code@siddh.me>,
Nick Alcock <nick.alcock@oracle.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Zack Rusin <zackr@vmware.com>
Cc: VMware Graphics Reviewers <linux-graphics-maintainer@vmware.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kexec@lists.infradead.org, linux-hardening@vger.kernel.org,
Philipp Stanner <pstanner@redhat.com>,
David Airlie <airlied@redhat.com>
Subject: [PATCH 4/5] drm_lease.c: copy user-array safely
Date: Wed, 30 Aug 2023 15:45:55 +0200 [thread overview]
Message-ID: <34e14523c9cea13e2f63afabf2938c89d2e84776.1693386602.git.pstanner@redhat.com> (raw)
In-Reply-To: <cover.1693386602.git.pstanner@redhat.com>
Currently, there is no overflow-check with memdup_user().
Use the new function memdup_array_user() instead of memdup_user() for
duplicating the user-space array safely.
Suggested-by: David Airlie <airlied@redhat.com>
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
---
drivers/gpu/drm/drm_lease.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c
index 150fe1555068..94375c6a5425 100644
--- a/drivers/gpu/drm/drm_lease.c
+++ b/drivers/gpu/drm/drm_lease.c
@@ -510,8 +510,8 @@ int drm_mode_create_lease_ioctl(struct drm_device *dev,
/* Handle leased objects, if any */
idr_init(&leases);
if (object_count != 0) {
- object_ids = memdup_user(u64_to_user_ptr(cl->object_ids),
- array_size(object_count, sizeof(__u32)));
+ object_ids = memdup_array_user(u64_to_user_ptr(cl->object_ids),
+ object_count, sizeof(__u32));
if (IS_ERR(object_ids)) {
ret = PTR_ERR(object_ids);
idr_destroy(&leases);
--
2.41.0
next prev parent reply other threads:[~2023-08-30 18:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 13:45 [PATCH 0/5] Introduce new wrappers to copy user-arrays Philipp Stanner
2023-08-30 13:45 ` [PATCH 1/5] string.h: add array-wrappers for (v)memdup_user() Philipp Stanner
2023-08-30 14:11 ` Andy Shevchenko
2023-08-30 14:19 ` pstanner
2023-08-30 14:29 ` Andy Shevchenko
2023-08-30 19:15 ` pstanner
2023-08-31 8:59 ` Andy Shevchenko
2023-08-31 12:16 ` Philipp Stanner
2023-08-31 12:22 ` Philipp Stanner
2023-08-31 13:16 ` Andy Shevchenko
2023-08-31 13:17 ` Andy Shevchenko
2023-08-30 14:15 ` Andy Shevchenko
2023-08-30 14:23 ` pstanner
2023-08-30 13:45 ` [PATCH 2/5] kernel: kexec: copy user-array safely Philipp Stanner
2023-08-30 13:45 ` [PATCH 3/5] kernel: watch_queue: " Philipp Stanner
2023-08-30 13:45 ` Philipp Stanner [this message]
2023-08-30 13:45 ` [PATCH 5/5] drm: vmgfx_surface.c: " Philipp Stanner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34e14523c9cea13e2f63afabf2938c89d2e84776.1693386602.git.pstanner@redhat.com \
--to=pstanner@redhat.com \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=andy@kernel.org \
--cc=brauner@kernel.org \
--cc=code@siddh.me \
--cc=daniel@ffwll.ch \
--cc=ddiss@suse.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=kexec@lists.infradead.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcgrof@kernel.org \
--cc=mripard@kernel.org \
--cc=nick.alcock@oracle.com \
--cc=tzimmermann@suse.de \
--cc=zackr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).