From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Philipp Stanner <pstanner@redhat.com>
Cc: Kees Cook <keescook@chromium.org>,
Andy Shevchenko <andy@kernel.org>,
Eric Biederman <ebiederm@xmission.com>,
Christian Brauner <brauner@kernel.org>,
David Disseldorp <ddiss@suse.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Siddh Raman Pant <code@siddh.me>,
Nick Alcock <nick.alcock@oracle.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Zack Rusin <zackr@vmware.com>,
VMware Graphics Reviewers <linux-graphics-maintainer@vmware.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kexec@lists.infradead.org, linux-hardening@vger.kernel.org,
David Airlie <airlied@redhat.com>
Subject: Re: [PATCH 1/5] string.h: add array-wrappers for (v)memdup_user()
Date: Thu, 31 Aug 2023 16:17:54 +0300 [thread overview]
Message-ID: <CAHp75Vc6Bj87V5HVZeNXJRmN1qBYP8_eDDSj5tLnfL7d81o9+w@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VcNyE9uJu8-v2eVWRdZ3-nm2r-kdxE-naQB4VN6zxPFxg@mail.gmail.com>
On Thu, Aug 31, 2023 at 4:16 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Thu, Aug 31, 2023 at 3:22 PM Philipp Stanner <pstanner@redhat.com> wrote:
> > On Wed, 2023-08-30 at 17:11 +0300, Andy Shevchenko wrote:
> > > On Wed, Aug 30, 2023 at 4:46 PM Philipp Stanner <pstanner@redhat.com>
> > > wrote:
...
> > > I'm wondering if this has no side-effects as string.h/string.c IIRC
> > > is used also for early stages where some of the APIs are not available.
> >
> > I forgot to address this point in my previous reply.
> >
> > Who's going to decide whether this is a problem or not?
> >
> > My personal guess is that this is unlikely to be a problem because
> >
> > A. either (v)memdup_user() is available, in which case
> > (v)memdup_array_user() will always work –
> > B. or (v)memdup_user() is not available, which would cause the code
> > that currently uses (v)memdup_user() for copying arrays to fail
> > anyways.
>
> It also uses something from overflow.h. I don't remember if that
> header was ever been used in early stage modules (like
> boot/decompressor).
Also we need to be sure UML is still buildable. Dunno if they are
using anything from this, but it appeared to me recently that someone
tried to optimize something using (internal) kernel headers and broke
the build in some cases.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-31 13:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 13:45 [PATCH 0/5] Introduce new wrappers to copy user-arrays Philipp Stanner
2023-08-30 13:45 ` [PATCH 1/5] string.h: add array-wrappers for (v)memdup_user() Philipp Stanner
2023-08-30 14:11 ` Andy Shevchenko
2023-08-30 14:19 ` pstanner
2023-08-30 14:29 ` Andy Shevchenko
2023-08-30 19:15 ` pstanner
2023-08-31 8:59 ` Andy Shevchenko
2023-08-31 12:16 ` Philipp Stanner
2023-08-31 12:22 ` Philipp Stanner
2023-08-31 13:16 ` Andy Shevchenko
2023-08-31 13:17 ` Andy Shevchenko [this message]
2023-08-30 14:15 ` Andy Shevchenko
2023-08-30 14:23 ` pstanner
2023-08-30 13:45 ` [PATCH 2/5] kernel: kexec: copy user-array safely Philipp Stanner
2023-08-30 13:45 ` [PATCH 3/5] kernel: watch_queue: " Philipp Stanner
2023-08-30 13:45 ` [PATCH 4/5] drm_lease.c: " Philipp Stanner
2023-08-30 13:45 ` [PATCH 5/5] drm: vmgfx_surface.c: " Philipp Stanner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vc6Bj87V5HVZeNXJRmN1qBYP8_eDDSj5tLnfL7d81o9+w@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=andy@kernel.org \
--cc=brauner@kernel.org \
--cc=code@siddh.me \
--cc=daniel@ffwll.ch \
--cc=ddiss@suse.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=kexec@lists.infradead.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcgrof@kernel.org \
--cc=mripard@kernel.org \
--cc=nick.alcock@oracle.com \
--cc=pstanner@redhat.com \
--cc=tzimmermann@suse.de \
--cc=zackr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).