From: Odelu Kukatla <quic_okukatla@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
<cros-qcom-dts-watchers@chromium.org>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-hardening@vger.kernel.org>, <quic_rlaggysh@quicinc.com>,
<quic_mdtipton@quicinc.com>
Subject: Re: [PATCH v3 2/4] interconnect: qcom: sc7280: enable QoS programming
Date: Wed, 20 Mar 2024 23:35:32 +0530 [thread overview]
Message-ID: <95045552-dd6c-49b1-ac39-e2d6151e171c@quicinc.com> (raw)
In-Reply-To: <3bace619-46fc-4f9f-bfb3-4c55cb4d8408@linaro.org>
On 3/6/2024 9:55 PM, Konrad Dybcio wrote:
>
>
> On 3/6/24 08:30, Odelu Kukatla wrote:
>> Enable QoS for the master ports with predefined values
>> for priority and urgency.
>>
>> Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com>
>> ---
>> drivers/interconnect/qcom/sc7280.c | 332 +++++++++++++++++++++++++++++
>> 1 file changed, 332 insertions(+)
>>
>> diff --git a/drivers/interconnect/qcom/sc7280.c b/drivers/interconnect/qcom/sc7280.c
>> index 7d33694368e8..1e1002c4d3d8 100644
>> --- a/drivers/interconnect/qcom/sc7280.c
>> +++ b/drivers/interconnect/qcom/sc7280.c
>> @@ -1,6 +1,7 @@
>> // SPDX-License-Identifier: GPL-2.0
>> /*
>> * Copyright (c) 2021, The Linux Foundation. All rights reserved.
>> + * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
>> *
>> */
>>
>> @@ -16,29 +17,53 @@
>> #include "icc-rpmh.h"
>> #include "sc7280.h"
>>
>> +static const struct qcom_icc_qosbox qhm_qspi_qos = {
>> + .num_ports = 1,
>> + .port_offsets = { 0x7000 },
>> + .prio = 2,
>> + .urg_fwd = 0,
>> +};
>> +
>> static struct qcom_icc_node qhm_qspi = {
>> .name = "qhm_qspi",
>> .id = SC7280_MASTER_QSPI_0,
>> .channels = 1,
>> .buswidth = 4,
>> + .qosbox = &qhm_qspi_qos,
>
> .qosbox = &(const struct qcom_icc_qosbox) {
> .num_ports = 1,
> ...
> },
>
I would like to keep as it is, it provides better readability for QoS parameters.
>
>
> Looks sensible otherwise
>
> Konrad
Thanks,
Odelu
next prev parent reply other threads:[~2024-03-20 18:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 7:30 [PATCH v3 0/4] Add support for QoS configuration Odelu Kukatla
2024-03-06 7:30 ` [PATCH v3 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support Odelu Kukatla
2024-03-06 8:31 ` Krzysztof Kozlowski
2024-03-20 17:51 ` Odelu Kukatla
2024-03-06 16:18 ` Konrad Dybcio
2024-03-20 17:59 ` Odelu Kukatla
2024-03-06 7:30 ` [PATCH v3 2/4] interconnect: qcom: sc7280: enable QoS programming Odelu Kukatla
2024-03-06 16:25 ` Konrad Dybcio
2024-03-20 18:05 ` Odelu Kukatla [this message]
2024-03-06 7:30 ` [PATCH v3 3/4] dt-bindings: interconnect: add clock property to enable QOS on SC7280 Odelu Kukatla
2024-03-06 8:26 ` Krzysztof Kozlowski
2024-03-20 17:08 ` Odelu Kukatla
2024-03-06 7:30 ` [PATCH v3 4/4] arm64: dts: qcom: sc7280: Add clocks for QOS configuration Odelu Kukatla
2024-03-12 10:35 ` Konrad Dybcio
2024-03-20 18:07 ` Odelu Kukatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95045552-dd6c-49b1-ac39-e2d6151e171c@quicinc.com \
--to=quic_okukatla@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_rlaggysh@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).