From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Odelu Kukatla <quic_okukatla@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
cros-qcom-dts-watchers@chromium.org,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, quic_rlaggysh@quicinc.com,
quic_mdtipton@quicinc.com
Subject: Re: [PATCH v3 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support
Date: Wed, 6 Mar 2024 17:18:44 +0100 [thread overview]
Message-ID: <b5ade82e-3a7e-427f-907f-bafe1d203d45@linaro.org> (raw)
In-Reply-To: <20240306073016.2163-2-quic_okukatla@quicinc.com>
On 3/6/24 08:30, Odelu Kukatla wrote:
> It adds QoS support for QNOC device and includes support for
> configuring priority, priority forward disable, urgency forwarding.
> This helps in priortizing the traffic originating from different
> interconnect masters at NoC(Network On Chip).
>
> Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com>
> ---
> drivers/interconnect/qcom/icc-rpmh.c | 105 +++++++++++++++++++++++++++
> drivers/interconnect/qcom/icc-rpmh.h | 32 ++++++++
> 2 files changed, 137 insertions(+)
>
> diff --git a/drivers/interconnect/qcom/icc-rpmh.c b/drivers/interconnect/qcom/icc-rpmh.c
> index c1aa265c1f4e..b4681849df80 100644
> --- a/drivers/interconnect/qcom/icc-rpmh.c
> +++ b/drivers/interconnect/qcom/icc-rpmh.c
> @@ -1,19 +1,57 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> * Copyright (c) 2020, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
> */
>
> +#include <linux/clk.h>
> #include <linux/interconnect.h>
> #include <linux/interconnect-provider.h>
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_platform.h>
> #include <linux/slab.h>
> +#include <linux/bitfield.h>
Please keep the alphabetical order
>
> #include "bcm-voter.h"
> #include "icc-common.h"
> #include "icc-rpmh.h"
>
> +/* QNOC QoS */
> +#define QOSGEN_MAINCTL_LO(p, qp) (0x8 + (p->port_offsets[qp]))
> +#define QOS_SLV_URG_MSG_EN_MASK BIT_MASK(3)
Mixing BIT_MASK and GENMASK is very confusing..
> +#define QOS_DFLT_PRIO_MASK GENMASK(6, 4)
> +#define QOS_DISABLE_MASK BIT_MASK(24)
> +
> +/**
> + * qcom_icc_set_qos - initialize static QoS configurations
> + * @qp: qcom icc provider to which @node belongs
> + * @node: qcom icc node to operate on
> + */
> +static void qcom_icc_set_qos(struct qcom_icc_provider *qp,
> + struct qcom_icc_node *node)
> +{
> + const struct qcom_icc_qosbox *qos = node->qosbox;
> + int port;
> +
> + if (!qp->regmap || !qos)
> + return;
This is not possible if you follow the code flow, I think..
[...]
> + * @prio: priority value assigned to requests on the node
> + * @urg_fwd: whether to forward the urgency promotion issued by master(endpoint), or discard
space before the opening brace, please also wrap to 80 lines
> + * @prio_fwd_disable: whether to forward the priority driven by mster, or override by @prio
typo: mster, please also wrap it
Konrad
next prev parent reply other threads:[~2024-03-06 16:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 7:30 [PATCH v3 0/4] Add support for QoS configuration Odelu Kukatla
2024-03-06 7:30 ` [PATCH v3 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support Odelu Kukatla
2024-03-06 8:31 ` Krzysztof Kozlowski
2024-03-20 17:51 ` Odelu Kukatla
2024-03-06 16:18 ` Konrad Dybcio [this message]
2024-03-20 17:59 ` Odelu Kukatla
2024-03-06 7:30 ` [PATCH v3 2/4] interconnect: qcom: sc7280: enable QoS programming Odelu Kukatla
2024-03-06 16:25 ` Konrad Dybcio
2024-03-20 18:05 ` Odelu Kukatla
2024-03-06 7:30 ` [PATCH v3 3/4] dt-bindings: interconnect: add clock property to enable QOS on SC7280 Odelu Kukatla
2024-03-06 8:26 ` Krzysztof Kozlowski
2024-03-20 17:08 ` Odelu Kukatla
2024-03-06 7:30 ` [PATCH v3 4/4] arm64: dts: qcom: sc7280: Add clocks for QOS configuration Odelu Kukatla
2024-03-12 10:35 ` Konrad Dybcio
2024-03-20 18:07 ` Odelu Kukatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5ade82e-3a7e-427f-907f-bafe1d203d45@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_okukatla@quicinc.com \
--cc=quic_rlaggysh@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).