From: Andrew Lunn <andrew@lunn.ch>
To: Marek Vasut <marex@denx.de>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH V5] net: phy: tja11xx: Add TJA11xx PHY driver
Date: Sat, 18 May 2019 22:12:51 +0200 [thread overview]
Message-ID: <20190518201251.GA30854@lunn.ch> (raw)
In-Reply-To: <b69b9b70-a299-2754-de9f-c7562b31fa16@denx.de>
On Sat, May 18, 2019 at 06:50:48PM +0200, Marek Vasut wrote:
> On 5/18/19 4:14 PM, Andrew Lunn wrote:
> > On Sat, May 18, 2019 at 01:51:23AM +0200, Marek Vasut wrote:
> >> Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special
> >> BroadRReach 100BaseT1 PHYs used in automotive.
> >
> > Hi Marek
>
> Hello Andrew,
>
> >> + }, {
> >> + PHY_ID_MATCH_MODEL(PHY_ID_TJA1101),
> >> + .name = "NXP TJA1101",
> >> + .features = PHY_BASIC_T1_FEATURES,
> >
> > One thing i would like to do before this patch goes in is define
> > ETHTOOL_LINK_MODE_100baseT1_Full_BIT in ethtool.h, and use it here.
> > We could not do it earlier because were ran out of bits. But with
> > PHYLIB now using bitmaps, rather than u32, we can.
> >
> > Once net-next reopens i will submit a patch adding it.
>
> I can understand blocking patches from being applied if they have review
> problems or need to be updated on some existing or even posted feature.
> But blocking a patch because some future yet-to-be-developed patch is a
> bit odd.
Hi Marek
What i'm trying to avoid is an ABI change. By using
PHY_BASIC_T1_FEATURES you are saying the device support 100BaseT. It
does not. It supports 100BaseT1. I want to add 100BaseT1 first, so
your PHY does not change from 100BaseT to 100BaseT1, which could be
considered an ABI change.
I'm not suggesting blocking your patch for a long time. I'm already
2/3 of the way doing the work. At the latest, i expect to have patches
submitted in the next few days. And then your driver can go in, using
this. So by end of next week, your driver can be in.
> > I also see in the data sheet we should be able to correct detect its
> > features using register 15. So we should extend
> > genphy_read_abilities().
>
> Which bits do you refer to ?
Register 15, bit 7. This indicates the PHY can do 100BaseT1. I want to
double check with the 802.3 standard, but i expect this is part of the
standard.
Andrew
next prev parent reply other threads:[~2019-05-18 20:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 23:51 [PATCH V5] net: phy: tja11xx: Add TJA11xx PHY driver Marek Vasut
2019-05-18 14:14 ` Andrew Lunn
2019-05-18 16:50 ` Marek Vasut
2019-05-18 20:12 ` Andrew Lunn [this message]
2019-05-18 20:46 ` Marek Vasut
2019-05-20 17:21 ` Florian Fainelli
2019-05-22 21:48 ` Marek Vasut
2019-05-22 22:14 ` Andrew Lunn
2019-05-22 22:42 ` Marek Vasut
2019-05-23 2:38 ` Florian Fainelli
2019-05-23 19:48 ` Vladimir Oltean
2019-05-24 11:41 ` Marek Vasut
2019-05-24 13:52 ` Andrew Lunn
2019-05-24 14:23 ` Marek Vasut
2019-05-24 14:28 ` Andrew Lunn
2019-05-27 15:44 ` Guenter Roeck
2019-05-28 18:17 ` Marek Vasut
2019-05-28 19:34 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190518201251.GA30854@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).