linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Marek Vasut <marex@denx.de>,
	netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Jean Delvare <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org
Subject: Re: [PATCH V5] net: phy: tja11xx: Add TJA11xx PHY driver
Date: Tue, 28 May 2019 21:34:45 +0200	[thread overview]
Message-ID: <20190528193445.GU18059@lunn.ch> (raw)
In-Reply-To: <e5e36955-732f-4b5b-50f7-78609fcae888@roeck-us.net>

On Mon, May 27, 2019 at 08:44:24AM -0700, Guenter Roeck wrote:
> >+static u32 tja11xx_hwmon_in_config[] = {
> >+	HWMON_I_LCRIT_ALARM,
> >+	0
> >+};
> >+
> >+static const struct hwmon_channel_info tja11xx_hwmon_in = {
> >+	.type		= hwmon_in,
> >+	.config		= tja11xx_hwmon_in_config,
> >+};
> >+
> >+static u32 tja11xx_hwmon_temp_config[] = {
> >+	HWMON_T_CRIT_ALARM,
> >+	0
> >+};
> >+
> >+static const struct hwmon_channel_info tja11xx_hwmon_temp = {
> >+	.type		= hwmon_temp,
> >+	.config		= tja11xx_hwmon_temp_config,
> >+};
> >+
> >+static const struct hwmon_channel_info *tja11xx_hwmon_info[] = {
> >+	&tja11xx_hwmon_in,
> >+	&tja11xx_hwmon_temp,
> >+	NULL
> >+};
> >+
> You might want to consider using the new HWMON_CHANNEL_INFO() macro
> to simplify above boilerplate code.

Hi Guenter

That is a nice simplification. Could you run the semantic patch
in drivers/net/phy and submit the results.

Thanks
	Andrew

      parent reply	other threads:[~2019-05-28 19:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17 23:51 [PATCH V5] net: phy: tja11xx: Add TJA11xx PHY driver Marek Vasut
2019-05-18 14:14 ` Andrew Lunn
2019-05-18 16:50   ` Marek Vasut
2019-05-18 20:12     ` Andrew Lunn
2019-05-18 20:46       ` Marek Vasut
2019-05-20 17:21     ` Florian Fainelli
2019-05-22 21:48   ` Marek Vasut
2019-05-22 22:14     ` Andrew Lunn
2019-05-22 22:42       ` Marek Vasut
2019-05-23  2:38 ` Florian Fainelli
2019-05-23 19:48   ` Vladimir Oltean
2019-05-24 11:41     ` Marek Vasut
2019-05-24 13:52       ` Andrew Lunn
2019-05-24 14:23         ` Marek Vasut
2019-05-24 14:28           ` Andrew Lunn
2019-05-27 15:44 ` Guenter Roeck
2019-05-28 18:17   ` Marek Vasut
2019-05-28 19:34   ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190528193445.GU18059@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marex@denx.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).