* [PATCH] ucd9000.c: Drop error checking for debugfs_create_dir
@ 2023-05-25 16:13 Osama Muhammad
2023-05-25 18:20 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Osama Muhammad @ 2023-05-25 16:13 UTC (permalink / raw)
To: linux, jdelvare; +Cc: linux-hwmon, linux-kernel, Osama Muhammad
This patch fixes the error checking in ucd9000.c.
The DebugFS kernel API is developed in
a way that the caller can safely ignore the errors that
occur during the creation of DebugFS nodes.
Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
---
drivers/hwmon/pmbus/ucd9000.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/hwmon/pmbus/ucd9000.c b/drivers/hwmon/pmbus/ucd9000.c
index 3daaf2237832..73559afa8ba7 100644
--- a/drivers/hwmon/pmbus/ucd9000.c
+++ b/drivers/hwmon/pmbus/ucd9000.c
@@ -512,8 +512,6 @@ static int ucd9000_init_debugfs(struct i2c_client *client,
return -ENOENT;
data->debugfs = debugfs_create_dir(client->name, debugfs);
- if (!data->debugfs)
- return -ENOENT;
/*
* Of the chips this driver supports, only the UCD9090, UCD90160,
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ucd9000.c: Drop error checking for debugfs_create_dir
2023-05-25 16:13 [PATCH] ucd9000.c: Drop error checking for debugfs_create_dir Osama Muhammad
@ 2023-05-25 18:20 ` Guenter Roeck
[not found] ` <CAK6rUAObC7_r1Riqfr7nd_B1BKx=abGXYk7F+5euGCiB2+xmWg@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2023-05-25 18:20 UTC (permalink / raw)
To: Osama Muhammad; +Cc: jdelvare, linux-hwmon, linux-kernel
On Thu, May 25, 2023 at 09:13:13PM +0500, Osama Muhammad wrote:
> This patch fixes the error checking in ucd9000.c.
Sure, but you should also explain what is wrong with the code
(i.e., that debugfs_create_dir() does not return NULL but an ERR_PTR
after an error).
> The DebugFS kernel API is developed in
> a way that the caller can safely ignore the errors that
> occur during the creation of DebugFS nodes.
>
If you plan t send more patches, please watch out for the subject line
to match subject lines used in a subsystem. Here it should start with
something like
hwmon: (pmbus/ucd9000) ...
Thanks,
Guenter
> Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
> ---
> drivers/hwmon/pmbus/ucd9000.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/ucd9000.c b/drivers/hwmon/pmbus/ucd9000.c
> index 3daaf2237832..73559afa8ba7 100644
> --- a/drivers/hwmon/pmbus/ucd9000.c
> +++ b/drivers/hwmon/pmbus/ucd9000.c
> @@ -512,8 +512,6 @@ static int ucd9000_init_debugfs(struct i2c_client *client,
> return -ENOENT;
>
> data->debugfs = debugfs_create_dir(client->name, debugfs);
> - if (!data->debugfs)
> - return -ENOENT;
>
> /*
> * Of the chips this driver supports, only the UCD9090, UCD90160,
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-25 19:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-25 16:13 [PATCH] ucd9000.c: Drop error checking for debugfs_create_dir Osama Muhammad
2023-05-25 18:20 ` Guenter Roeck
[not found] ` <CAK6rUAObC7_r1Riqfr7nd_B1BKx=abGXYk7F+5euGCiB2+xmWg@mail.gmail.com>
2023-05-25 19:57 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).