From: Guenter Roeck <linux@roeck-us.net>
To: Alexander Monakov <amonakov@ispras.ru>
Cc: Naveen Krishna Ch <naveenkrishna.ch@gmail.com>,
Naveen Krishna Chatradhi <nchatrad@amd.com>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 1/3 v7] hwmon: Add amd_energy driver to report energy counters
Date: Wed, 27 May 2020 08:35:24 -0700 [thread overview]
Message-ID: <3a7b3724-86e8-d503-ff4b-43d2bb5074ae@roeck-us.net> (raw)
In-Reply-To: <alpine.LNX.2.20.13.2005271823000.18802@monopod.intra.ispras.ru>
On 5/27/20 8:25 AM, Alexander Monakov wrote:
> On Wed, 27 May 2020, Guenter Roeck wrote:
>
>>> In the current driver, the accumulation thread starts during the probe and the
>>> prev_value of sockets and the core0 is updated with the current MSR value.
>>> It takes (nr_cpus - 1) iterations of the thread to populate the prev_value for
>>> the other cores.
>>>
>>> By populating prev_value of all the cores during probe, we can
>>> certainly save some
>>> information (values with in one wrap-around at the best). If this
>>> information is
>>> useful, i can submit a patch to do so. Guenter, could you suggest us on this.
>>>
>>
>> As long as you don't ignore counter values from before loading the driver,
>> sure, go ahead.
>
> Hm? If I'm understanding correctly what Naveen is proposing, that would simply
> move reading the initial values ahead by a few hundred cycles (the latency to
> start the thread). It wouldn't change anything about the issue, and make the
> code more complicated :(
>
At this point the question is if I should drop this driver entirely.
Guenter
next prev parent reply other threads:[~2020-05-27 15:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 15:50 [PATCH 1/3 v7] hwmon: Add amd_energy driver to report energy counters Naveen Krishna Chatradhi
2020-05-19 15:50 ` [PATCH 2/3 v7] hwmon: (amd_energy) Add documentation Naveen Krishna Chatradhi
2020-05-19 15:50 ` [PATCH 3/3 v7] MAINTAINERS: add entry for AMD energy driver Naveen Krishna Chatradhi
2020-05-22 13:26 ` [PATCH 1/3 v7] hwmon: Add amd_energy driver to report energy counters Guenter Roeck
2020-05-22 14:19 ` Naveen Krishna Ch
2020-05-26 22:37 ` Alexander Monakov
2020-05-27 3:03 ` Naveen Krishna Ch
2020-05-27 6:59 ` Alexander Monakov
2020-05-27 10:35 ` Naveen Krishna Ch
2020-05-27 13:28 ` Guenter Roeck
2020-05-27 14:08 ` Alexander Monakov
2020-05-27 14:42 ` Naveen Krishna Ch
2020-05-27 15:15 ` Guenter Roeck
2020-05-27 15:25 ` Alexander Monakov
2020-05-27 15:35 ` Guenter Roeck [this message]
2020-05-27 14:48 ` Guenter Roeck
2020-05-27 15:12 ` Alexander Monakov
2020-05-27 15:33 ` Guenter Roeck
2020-05-27 16:41 ` Alexander Monakov
2020-05-27 16:57 ` Guenter Roeck
2020-05-27 17:12 ` Alexander Monakov
2020-05-27 16:59 ` Alexander Monakov
2020-05-28 4:11 ` Naveen Krishna Ch
2020-06-10 20:21 ` Alexander Monakov
2020-06-16 14:46 ` Chatradhi, Naveen Krishna
2020-06-16 14:53 ` Guenter Roeck
2020-06-16 14:57 ` Naveen Krishna Ch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a7b3724-86e8-d503-ff4b-43d2bb5074ae@roeck-us.net \
--to=linux@roeck-us.net \
--cc=amonakov@ispras.ru \
--cc=linux-hwmon@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=nchatrad@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).