From: Linus Walleij <linus.walleij@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, Peter Rosin <peda@axentia.se>,
Chris Lesiak <chris.lesiak@licor.com>,
Jonathan Cameron <jic23@cam.ac.uk>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] hwmon: (ntc_thermistor): try reading processed
Date: Thu, 24 Dec 2020 01:47:38 +0100 [thread overview]
Message-ID: <CACRpkdYJSE_wSf72N=oX+JogdTF-FBSqkeMZghrr1ytmPY8apQ@mail.gmail.com> (raw)
In-Reply-To: <d990e08f-6f18-836d-89a5-01102a4faa45@roeck-us.net>
On Wed, Dec 23, 2020 at 10:42 PM Guenter Roeck <linux@roeck-us.net> wrote:
> You don't
> answer the basic question: What should the driver do if the iio
> subsystem only delivers raw values ? I suggested we should just keep
> the current assumption in this case, ie do the fixed conversion,
> and let userspace handle any necessary adjustments. You seem to object.
> With your patch, we get a comment in the driver suggesting that some
> code should be removed. In my opinion, such a comment comment does
> not add any value. Ether we drop the code or we don't, and I dislike
> removing it.
>
> That results in my usual fallback: When in doubt, do nothing.
OK I get it, I'll fix it up along with the confused bug pointed out by
Chris and resend.
Thanks!
Linus Walleij
next prev parent reply other threads:[~2020-12-24 0:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 22:41 [PATCH] hwmon: (ntc_thermistor): try reading processed Linus Walleij
2020-12-21 16:15 ` Guenter Roeck
2020-12-23 21:08 ` Linus Walleij
2020-12-23 21:42 ` Guenter Roeck
2020-12-24 0:47 ` Linus Walleij [this message]
2020-12-23 22:39 ` Chris Lesiak
[not found] ` <SN6PR08MB5565DD42F17BA93D362DB95B9ADE0@SN6PR08MB5565.namprd08.prod.outlook.com>
2020-12-24 0:39 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYJSE_wSf72N=oX+JogdTF-FBSqkeMZghrr1ytmPY8apQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=chris.lesiak@licor.com \
--cc=jdelvare@suse.com \
--cc=jic23@cam.ac.uk \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).