From: Linus Walleij <linus.walleij@linaro.org>
To: Chris Lesiak <chris.lesiak@licor.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
Peter Rosin <peda@axentia.se>, Jonathan Cameron <jic23@cam.ac.uk>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] hwmon: (ntc_thermistor): try reading processed
Date: Thu, 24 Dec 2020 01:39:22 +0100 [thread overview]
Message-ID: <CACRpkdaVN9gf4PWh=_UcJ23kC47XChREgiBh-46wV8VRFkUtdw@mail.gmail.com> (raw)
In-Reply-To: <SN6PR08MB5565DD42F17BA93D362DB95B9ADE0@SN6PR08MB5565.namprd08.prod.outlook.com>
Hi Chris!
Thanks for stepping in!
On Wed, Dec 23, 2020 at 11:24 PM Chris Lesiak <chris.lesiak@licor.com> wrote:
> I'm the author of commit 0315253b19bbc63eedad2f6125c21e280c76e29b
> "hwmon: (ntc_thermistor) fix iio raw to microvolts conversion".
>
> The 1000X scaling was not to get around a bad ADC driver that returns volts instead of
> millivolts; it was to convert millivolts to microvolts. The function ntc_adc_iio_read
> needs to return microvolts.
Sorry for my confusion of terms.
I see my mistake, I'll update the patch to scale the returned value
from millivolts to microvolts and respin!
Yours,
Linus Walleij
prev parent reply other threads:[~2020-12-24 0:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 22:41 [PATCH] hwmon: (ntc_thermistor): try reading processed Linus Walleij
2020-12-21 16:15 ` Guenter Roeck
2020-12-23 21:08 ` Linus Walleij
2020-12-23 21:42 ` Guenter Roeck
2020-12-24 0:47 ` Linus Walleij
2020-12-23 22:39 ` Chris Lesiak
[not found] ` <SN6PR08MB5565DD42F17BA93D362DB95B9ADE0@SN6PR08MB5565.namprd08.prod.outlook.com>
2020-12-24 0:39 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdaVN9gf4PWh=_UcJ23kC47XChREgiBh-46wV8VRFkUtdw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=chris.lesiak@licor.com \
--cc=jdelvare@suse.com \
--cc=jic23@cam.ac.uk \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).