From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Max Staudt <max@enpas.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
linux-hwmon@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
"Linux/m68k" <linux-m68k@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: Re: [PATCH v5 1/3] i2c/busses: Add i2c-icy for I2C on m68k/Amiga
Date: Tue, 20 Aug 2019 11:08:00 +0200 [thread overview]
Message-ID: <CAMuHMdU=18qtZi7N8+i9cJbKVL+pOB-wttnRRu_mOcMNymF_3w@mail.gmail.com> (raw)
In-Reply-To: <20190819121618.16557-1-max@enpas.org>
On Mon, Aug 19, 2019 at 2:17 PM Max Staudt <max@enpas.org> wrote:
> This is the i2c-icy driver for the ICY board for Amiga computers.
> It connects a PCF8584 I2C controller to the Zorro bus, providing I2C
> connectivity. The original documentation can be found on Aminet:
>
> https://aminet.net/package/docs/hard/icy
>
> IRQ support is currently not implemented, as i2c-algo-pcf is built for
> the ISA bus and a straight implementation of the same stack locks up a
> Zorro machine.
>
> v5: usleep_range() instead of udelay()
> Style
>
> v3: Fixed %pa format string
> Dropped adapter class.
> Clarified licence.
> Removed clock parameter.
>
> v2: Matched function names to callbacks from i2c-algo-pcf
> Used z_readb()/z_writeb()
> Removed BROKEN_ON_SMP in Kconfig
> Moved LTC2990 to a separate commit
>
> Signed-off-by: Max Staudt <max@enpas.org>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> --- /dev/null
> +++ b/drivers/i2c/busses/i2c-icy.c
> +static int icy_pcf_getpcf(void *data, int ctl)
> +{
> + struct icy_i2c *i2c = (struct icy_i2c *)data;
> +
> + u8 __iomem *address = ctl ? i2c->reg_s1 : i2c->reg_s0;
> + int val = z_readb(address);
> +
> + return val;
return z_readb(address);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-08-20 9:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 12:16 [PATCH v5 1/3] i2c/busses: Add i2c-icy for I2C on m68k/Amiga Max Staudt
2019-08-19 12:16 ` [PATCH v5 2/3] hwmon/ltc2990: Generalise DT to fwnode support Max Staudt
2019-08-20 9:09 ` Geert Uytterhoeven
2019-08-20 15:07 ` Guenter Roeck
2019-08-20 15:08 ` Max Staudt
2019-08-19 12:16 ` [PATCH v5 3/3] i2c/busses/i2c-icy: Add LTC2990 present on 2019 board revision Max Staudt
2019-08-20 9:18 ` Geert Uytterhoeven
2019-08-20 9:22 ` Max
2019-08-29 19:06 ` Wolfram Sang
2019-08-20 9:08 ` Geert Uytterhoeven [this message]
2019-08-20 9:23 ` [PATCH v5 1/3] i2c/busses: Add i2c-icy for I2C on m68k/Amiga Max
2019-08-20 9:27 ` [PATCH] " Max Staudt
2019-08-29 19:00 ` Wolfram Sang
2019-08-29 19:17 ` Max Staudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdU=18qtZi7N8+i9cJbKVL+pOB-wttnRRu_mOcMNymF_3w@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=max@enpas.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).