From: Greg KH <gregkh@linuxfoundation.org>
To: lantianyu1986@gmail.com
Cc: alex.williamson@redhat.com, cohuck@redhat.com, kys@microsoft.com,
haiyangz@microsoft.com, sthemmin@microsoft.com,
sashal@kernel.org, mchehab+samsung@kernel.org,
davem@davemloft.net, robh@kernel.org,
Jonathan.Cameron@huawei.com, paulmck@linux.ibm.com,
michael.h.kelley@microsoft.com,
Tianyu Lan <Tianyu.Lan@microsoft.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-hyperv@vger.kernel.org, vkuznets@redhat.com
Subject: Re: [PATCH] VFIO/VMBUS: Add VFIO VMBUS driver support
Date: Mon, 11 Nov 2019 10:49:20 +0100 [thread overview]
Message-ID: <20191111094920.GA135867@kroah.com> (raw)
In-Reply-To: <20191111084507.9286-1-Tianyu.Lan@microsoft.com>
On Mon, Nov 11, 2019 at 04:45:07PM +0800, lantianyu1986@gmail.com wrote:
> +#define DRIVER_VERSION "0.0.1"
Never a need for DRIVER_VERSION as your driver just becomes part of the
main kernel tree, so please drop this. We keep trying to delete these
types of numbers and they keep coming back...
> +static void
> +vfio_vmbus_new_channel(struct vmbus_channel *new_sc)
> +{
> + struct hv_device *hv_dev = new_sc->primary_channel->device_obj;
> + struct device *device = &hv_dev->device;
> + int ret;
> +
> + /* Create host communication ring */
> + ret = vmbus_open(new_sc, HV_RING_SIZE, HV_RING_SIZE, NULL, 0,
> + vfio_vmbus_channel_cb, new_sc);
> + if (ret) {
> + dev_err(device, "vmbus_open subchannel failed: %d\n", ret);
> + return;
> + }
> +
> + /* Disable interrupts on sub channel */
> + new_sc->inbound.ring_buffer->interrupt_mask = 1;
> + set_channel_read_mode(new_sc, HV_CALL_ISR);
> +
> + ret = sysfs_create_bin_file(&new_sc->kobj, &ring_buffer_bin_attr);
No documentation on this new sysfs file?
And by creating it here, userspace is not notified of it, so tools will
not see it :(
> + if (ret)
> + dev_notice(&hv_dev->device,
> + "sysfs create ring bin file failed; %d\n", ret);
Doesn't the call spit out an error if something happens?
> + ret = sysfs_create_bin_file(&channel->kobj, &ring_buffer_bin_attr);
> + if (ret)
> + dev_notice(&dev->device,
> + "sysfs create ring bin file failed; %d\n", ret);
> +
Again, don't create sysfs files on your own, the bus code should be
doing this for you automatically and in a way that is race-free.
thanks,
greg k-h
next prev parent reply other threads:[~2019-11-11 9:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 8:45 [PATCH] VFIO/VMBUS: Add VFIO VMBUS driver support lantianyu1986
2019-11-11 9:49 ` Greg KH [this message]
2019-11-11 16:47 ` Stephen Hemminger
2019-11-11 17:23 ` Greg KH
2019-11-11 17:29 ` Stephen Hemminger
2019-11-19 23:37 ` Michael Kelley
2019-11-19 23:56 ` Alex Williamson
2019-11-20 18:35 ` Stephen Hemminger
2019-11-20 19:07 ` Alex Williamson
2019-11-20 19:46 ` Stephen Hemminger
2019-11-20 20:31 ` Alex Williamson
2019-11-20 23:18 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111094920.GA135867@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=lantianyu1986@gmail.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=michael.h.kelley@microsoft.com \
--cc=paulmck@linux.ibm.com \
--cc=robh@kernel.org \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).