From: Alex Williamson <alex.williamson@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <lantianyu1986@gmail.com>, <cohuck@redhat.com>,
"KY Srinivasan" <kys@microsoft.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Stephen Hemminger" <sthemmin@microsoft.com>, <sashal@kernel.org>,
<mchehab+samsung@kernel.org>, <davem@davemloft.net>,
<gregkh@linuxfoundation.org>, <robh@kernel.org>,
<Jonathan.Cameron@huawei.com>, <paulmck@linux.ibm.com>,
"Michael Kelley" <mikelley@microsoft.com>,
"Tianyu Lan" <Tianyu.Lan@microsoft.com>,
<linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>,
<linux-hyperv@vger.kernel.org>, "vkuznets" <vkuznets@redhat.com>
Subject: Re: [PATCH] VFIO/VMBUS: Add VFIO VMBUS driver support
Date: Wed, 20 Nov 2019 12:07:15 -0700 [thread overview]
Message-ID: <20191120120715.0cecf5ea@x1.home> (raw)
In-Reply-To: <20191120103503.5f7bd7c4@hermes.lan>
On Wed, 20 Nov 2019 10:35:03 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:
> On Tue, 19 Nov 2019 15:56:20 -0800
> "Alex Williamson" <alex.williamson@redhat.com> wrote:
>
> > On Mon, 11 Nov 2019 16:45:07 +0800
> > lantianyu1986@gmail.com wrote:
> >
> > > From: Tianyu Lan <Tianyu.Lan@microsoft.com>
> > >
> > > This patch is to add VFIO VMBUS driver support in order to expose
> > > VMBUS devices to user space drivers(Reference Hyper-V UIO driver).
> > > DPDK now has netvsc PMD driver support and it may get VMBUS resources
> > > via VFIO interface with new driver support.
> > >
> > > So far, Hyper-V doesn't provide virtual IOMMU support and so this
> > > driver needs to be used with VFIO noiommu mode.
> >
> > Let's be clear here, vfio no-iommu mode taints the kernel and was a
> > compromise that we can re-use vfio-pci in its entirety, so it had a
> > high code reuse value for minimal code and maintenance investment. It
> > was certainly not intended to provoke new drivers that rely on this mode
> > of operation. In fact, no-iommu should be discouraged as it provides
> > absolutely no isolation. I'd therefore ask, why should this be in the
> > kernel versus any other unsupportable out of tree driver? It appears
> > almost entirely self contained. Thanks,
> >
> > Alex
>
> The current VMBUS access from userspace is from uio_hv_generic
> there is (and will not be) any out of tree driver for this.
I'm talking about the driver proposed here. It can only be used in a
mode that taints the kernel that its running on, so why would we sign
up to support 400 lines of code that has no safe way to use it?
> The new driver from Tianyu is to make VMBUS behave like PCI.
> This simplifies the code for DPDK and other usermode device drivers
> because it can use the same API's for VMBus as is done for PCI.
But this doesn't re-use the vfio-pci API at all, it explicitly defines
a new vfio-vmbus API over the vfio interfaces. So a user mode driver
might be able to reuse some vfio support, but I don't see how this has
anything to do with PCI.
> Unfortunately, since Hyper-V does not support virtual IOMMU yet,
> the only usage modle is with no-iommu taint.
Which is what makes it unsupportable and prompts the question why it
should be included in the mainline kernel as it introduces a
maintenance burden and normalizes a usage model that's unsafe. Thanks,
Alex
next prev parent reply other threads:[~2019-11-20 19:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 8:45 [PATCH] VFIO/VMBUS: Add VFIO VMBUS driver support lantianyu1986
2019-11-11 9:49 ` Greg KH
2019-11-11 16:47 ` Stephen Hemminger
2019-11-11 17:23 ` Greg KH
2019-11-11 17:29 ` Stephen Hemminger
2019-11-19 23:37 ` Michael Kelley
2019-11-19 23:56 ` Alex Williamson
2019-11-20 18:35 ` Stephen Hemminger
2019-11-20 19:07 ` Alex Williamson [this message]
2019-11-20 19:46 ` Stephen Hemminger
2019-11-20 20:31 ` Alex Williamson
2019-11-20 23:18 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120120715.0cecf5ea@x1.home \
--to=alex.williamson@redhat.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=cohuck@redhat.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=lantianyu1986@gmail.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mikelley@microsoft.com \
--cc=paulmck@linux.ibm.com \
--cc=robh@kernel.org \
--cc=sashal@kernel.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).