* [PATCH] i2c/busses: fix spellint typo
@ 2021-02-25 11:53 zuoqilin1
2021-02-27 10:00 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: zuoqilin1 @ 2021-02-25 11:53 UTC (permalink / raw)
To: jdelvare; +Cc: linux-i2c, linux-kernel, zuoqilin
From: zuoqilin <zuoqilin@yulong.com>
change 'adress' to 'address'
Signed-off-by: zuoqilin <zuoqilin@yulong.com>
---
drivers/i2c/busses/i2c-sis630.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis630.c
index cfb8e04..87d5625 100644
--- a/drivers/i2c/busses/i2c-sis630.c
+++ b/drivers/i2c/busses/i2c-sis630.c
@@ -97,7 +97,7 @@
module_param(force, bool, 0);
MODULE_PARM_DESC(force, "Forcibly enable the SIS630. DANGEROUS!");
-/* SMBus base adress */
+/* SMBus base address */
static unsigned short smbus_base;
/* supported chips */
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c/busses: fix spellint typo
2021-02-25 11:53 [PATCH] i2c/busses: fix spellint typo zuoqilin1
@ 2021-02-27 10:00 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2021-02-27 10:00 UTC (permalink / raw)
To: zuoqilin1; +Cc: linux-i2c, linux-kernel, zuoqilin
Hi zuoqilin,
There's an obvious typo in the subject. Which is kind of ironical
considering the point of your patch.
Also, your patch is driver-specific, so "i2c/busses:" isn't an
appropriate prefix. According to the standard practice for the i2c
subsystem, the proper prefix for the subject would be: "i2c: sis630:".
On Thu, 25 Feb 2021 19:53:38 +0800, zuoqilin1@163.com wrote:
> From: zuoqilin <zuoqilin@yulong.com>
>
> change 'adress' to 'address'
Please start your sentences with a capital and end them with a dot.
>
> Signed-off-by: zuoqilin <zuoqilin@yulong.com>
> ---
> drivers/i2c/busses/i2c-sis630.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis630.c
> index cfb8e04..87d5625 100644
> --- a/drivers/i2c/busses/i2c-sis630.c
> +++ b/drivers/i2c/busses/i2c-sis630.c
> @@ -97,7 +97,7 @@
> module_param(force, bool, 0);
> MODULE_PARM_DESC(force, "Forcibly enable the SIS630. DANGEROUS!");
>
> -/* SMBus base adress */
> +/* SMBus base address */
> static unsigned short smbus_base;
>
> /* supported chips */
Other than that, the change looks OK, thanks.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-27 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 11:53 [PATCH] i2c/busses: fix spellint typo zuoqilin1
2021-02-27 10:00 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).