* [PATCH] libata: Add NOLPM quirk for SAMSUNG MZ7TE512HMHP-000L1 SSD
@ 2019-02-03 9:02 Hans de Goede
[not found] ` <20190205185201.B3870217F9@mail.kernel.org>
2019-02-06 19:47 ` Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: Hans de Goede @ 2019-02-03 9:02 UTC (permalink / raw)
To: Jens Axboe; +Cc: Hans de Goede, linux-ide, stable
We've received a bugreport that using LPM with a SAMSUNG
MZ7TE512HMHP-000L1 SSD leads to system instability, we already have
a quirk for the MZ7TD256HAFV-000L9, which is also a Samsun EVO 840 /
PM851 OEM model, so it seems some of these models have a LPM issue.
This commits adds a NOLPM quirk for the model string from the new
bugeport, to avoid the reported stability issues.
Cc: stable@vger.kernel.org
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1571330
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/ata/libata-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b8c3f9e6af89..adf28788cab5 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4554,6 +4554,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
{ "SAMSUNG SSD PM830 mSATA *", "CXM13D1Q", ATA_HORKAGE_NOLPM, },
{ "SAMSUNG MZ7TD256HAFV-000L9", NULL, ATA_HORKAGE_NOLPM, },
+ { "SAMSUNG MZ7TE512HMHP-000L1", "EXT06L0Q", ATA_HORKAGE_NOLPM, },
/* devices that don't properly handle queued TRIM commands */
{ "Micron_M500IT_*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM |
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] libata: Add NOLPM quirk for SAMSUNG MZ7TE512HMHP-000L1 SSD
[not found] ` <20190205185201.B3870217F9@mail.kernel.org>
@ 2019-02-06 19:00 ` Hans de Goede
2019-02-06 19:00 ` Hans de Goede
1 sibling, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2019-02-06 19:00 UTC (permalink / raw)
To: Sasha Levin, Jens Axboe; +Cc: linux-ide, stable
Hi,
On 05-02-19 19:52, Sasha Levin wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
>
> The bot has tested the following trees: v4.20.6, v4.19.19, v4.14.97, v4.9.154, v4.4.172, v3.18.133.
>
> v4.20.6: Build OK!
> v4.19.19: Build OK!
> v4.14.97: Failed to apply! Possible dependencies:
> 410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
> 76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
> a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
> b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")
The code to enable LPM support by default on mobile chipsets was merged
in the 4.16 kernel, so 4.14 (and older) don't need these blacklist patches
since they don't enable LPM by default (the user needs to write to a sysfs
attribute to enable it).
So it is fine to leave this patch out of 4.14.z and older.
Regards,
Hans
>
> v4.9.154: Failed to apply! Possible dependencies:
> 410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
> 76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
> a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
> b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")
>
> v4.4.172: Failed to apply! Possible dependencies:
> 410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
> 76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
> a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
> b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")
>
> v3.18.133: Failed to apply! Possible dependencies:
> 410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
> 76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
> a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
> b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")
>
>
> How should we proceed with this patch?
>
> --
> Thanks,
> Sasha
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libata: Add NOLPM quirk for SAMSUNG MZ7TE512HMHP-000L1 SSD
[not found] ` <20190205185201.B3870217F9@mail.kernel.org>
2019-02-06 19:00 ` Hans de Goede
@ 2019-02-06 19:00 ` Hans de Goede
1 sibling, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2019-02-06 19:00 UTC (permalink / raw)
To: Sasha Levin, Jens Axboe; +Cc: linux-ide, stable
Hi,
On 05-02-19 19:52, Sasha Levin wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
>
> The bot has tested the following trees: v4.20.6, v4.19.19, v4.14.97, v4.9.154, v4.4.172, v3.18.133.
>
> v4.20.6: Build OK!
> v4.19.19: Build OK!
> v4.14.97: Failed to apply! Possible dependencies:
> 410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
> 76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
> a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
> b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")
The code to enable LPM support by default on mobile chipsets was merged
in the 4.16 kernel, so 4.14 (and older) don't need these blacklist patches
since they don't enable LPM by default (the user needs to write to a sysfs
attribute to enable it).
So it is fine to leave this patch out of 4.14.z and older.
Regards,
Hans
>
> v4.9.154: Failed to apply! Possible dependencies:
> 410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
> 76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
> a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
> b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")
>
> v4.4.172: Failed to apply! Possible dependencies:
> 410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
> 76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
> a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
> b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")
>
> v3.18.133: Failed to apply! Possible dependencies:
> 410b5c7b4836 ("libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD")
> 76936e9a6df1 ("libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.")
> a435ab4f80f9 ("libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9")
> b5b4d3a52c8f ("libata: Apply NOLPM quirk for SAMSUNG MZMPC128HBFU-000MV SSD")
>
>
> How should we proceed with this patch?
>
> --
> Thanks,
> Sasha
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libata: Add NOLPM quirk for SAMSUNG MZ7TE512HMHP-000L1 SSD
2019-02-03 9:02 [PATCH] libata: Add NOLPM quirk for SAMSUNG MZ7TE512HMHP-000L1 SSD Hans de Goede
[not found] ` <20190205185201.B3870217F9@mail.kernel.org>
@ 2019-02-06 19:47 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2019-02-06 19:47 UTC (permalink / raw)
To: Hans de Goede; +Cc: linux-ide, stable
On 2/3/19 2:02 AM, Hans de Goede wrote:
> We've received a bugreport that using LPM with a SAMSUNG
> MZ7TE512HMHP-000L1 SSD leads to system instability, we already have
> a quirk for the MZ7TD256HAFV-000L9, which is also a Samsun EVO 840 /
> PM851 OEM model, so it seems some of these models have a LPM issue.
>
> This commits adds a NOLPM quirk for the model string from the new
> bugeport, to avoid the reported stability issues.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-06 19:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-03 9:02 [PATCH] libata: Add NOLPM quirk for SAMSUNG MZ7TE512HMHP-000L1 SSD Hans de Goede
[not found] ` <20190205185201.B3870217F9@mail.kernel.org>
2019-02-06 19:00 ` Hans de Goede
2019-02-06 19:00 ` Hans de Goede
2019-02-06 19:47 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).