From: Guenter Roeck <linux@roeck-us.net>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bart Van Assche <bvanassche@acm.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH v2] hwmon: Driver for temperature sensors on SATA drives
Date: Wed, 8 Jan 2020 07:32:22 -0800 [thread overview]
Message-ID: <20200108153222.GA28530@roeck-us.net> (raw)
In-Reply-To: <yq1o8ve20sb.fsf@oracle.com>
Hi Martin,
On Tue, Jan 07, 2020 at 08:29:40PM -0500, Martin K. Petersen wrote:
>
> Guenter,
>
> > "scsi-8-140" is created by libsensors, so any change in that would
> > have to be made there, not in the kernel driver.
>
> Yes. Something like the patch below which will produce actual SCSI
> device instance names:
>
> drivetemp-scsi-7:0:29:0
> drivetemp-scsi-8:0:30:0
> drivetemp-scsi-8:0:15:0
> drivetemp-scsi-7:0:24:0
>
> Instead of the current:
>
> drivetemp-scsi-7-1d0
> drivetemp-scsi-8-1e0
> drivetemp-scsi-8-f0
> drivetemp-scsi-7-180
>
> Other question: Does hwmon have any notion of sensor topology? As I
> mentioned earlier, SCSI installations typically rely on SAF-TE or SES
> instead of the physical drive sensors. SES also includes monitoring of
> fans, power supplies, etc. And more importantly, it provides a
> representation of the location of a given component. E.g.: Tray number
> #4, disk drive bay #5.
>
Please go ahead and submit the patch for libsensors.
> So it would be helpful if libsensors had a way to represent sensors in a
> way that mimics the physical device layout reported by SES.
>
I guess it would be up to you to come up with a proposal.
Thanks,
Guenter
next prev parent reply other threads:[~2020-01-08 15:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 17:45 [PATCH v2 0/1] Summary: hwmon driver for temperature sensors on SATA drives Guenter Roeck
2019-12-15 17:45 ` [PATCH v2] hwmon: Driver " Guenter Roeck
2019-12-19 0:15 ` Martin K. Petersen
2019-12-19 0:32 ` Guenter Roeck
2020-01-07 4:10 ` Martin K. Petersen
2020-01-07 13:00 ` Guenter Roeck
2020-01-08 1:29 ` Martin K. Petersen
2020-01-08 15:32 ` Guenter Roeck [this message]
2019-12-19 7:37 ` Guenter Roeck
2020-01-01 17:46 ` Guenter Roeck
2020-01-03 3:06 ` Martin K. Petersen
2020-01-08 1:12 ` Martin K. Petersen
2020-01-08 15:33 ` Guenter Roeck
2020-01-11 20:22 ` Guenter Roeck
2020-01-12 11:17 ` Gabriel C
2020-01-12 11:21 ` Linus Walleij
2020-01-12 12:02 ` Gabriel C
2020-01-12 12:07 ` Linus Walleij
2020-01-12 13:07 ` Guenter Roeck
2020-01-12 13:45 ` Gabriel C
2020-01-12 15:26 ` Guenter Roeck
2020-01-12 18:37 ` Gabriel C
2020-01-12 20:08 ` Guenter Roeck
2020-01-12 22:26 ` Gabriel C
2020-01-14 3:03 ` Martin K. Petersen
2020-01-14 5:20 ` Guenter Roeck
2020-01-16 4:12 ` Martin K. Petersen
2020-01-16 5:09 ` Guenter Roeck
2020-01-16 17:47 ` Guenter Roeck
2020-01-17 1:43 ` Martin K. Petersen
2020-01-17 3:53 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108153222.GA28530@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bvanassche@acm.org \
--cc=cphealy@gmail.com \
--cc=jdelvare@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).