From: Jonathan Cameron <jic23@kernel.org> To: Stefan Popa <stefan.popa@analog.com> Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <knaack.h@gmx.de>, <lars@metafoo.de>, <pmeerw@pmeerw.net>, <Michael.Hennerich@analog.com>, <gregkh@linuxfoundation.org>, <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 2/2] dt-bindings: iio: adc: Add docs for AD7606 ADC Date: Sat, 1 Dec 2018 17:00:46 +0000 [thread overview] Message-ID: <20181201170046.13eef1fc@archlinux> (raw) In-Reply-To: <1543510663-14921-1-git-send-email-stefan.popa@analog.com> On Thu, 29 Nov 2018 18:57:43 +0200 Stefan Popa <stefan.popa@analog.com> wrote: > Document support for AD7606 Analog to Digital Converter. >=20 > Signed-off-by: Stefan Popa <stefan.popa@analog.com> Looks good to me, but as it's a non trivial binding in complexity I'd definitely like a DT maintainers input before applying this. Thanks, Jonathan > --- > Changes in v2: > - fixed indentation issues. > - used gpios instead of gpio. > - added vendor prefix for conversion-start-gpios, first-data-gpios, > and range-gpios. > Changes in v3: > - Added adi,oversampling-ratio-gpios. >=20 > .../devicetree/bindings/iio/adc/adi,ad7606.txt | 54 ++++++++++++++++= ++++++ > MAINTAINERS | 1 + > 2 files changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7606.= txt >=20 > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt b/D= ocumentation/devicetree/bindings/iio/adc/adi,ad7606.txt > new file mode 100644 > index 0000000..02fae23 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt > @@ -0,0 +1,54 @@ > +Analog Devices AD7606 Simultaneous Sampling ADC > + > +Required properties for the AD7606: > + > +- compatible: Must be one of > + * "adi,ad7605-4" > + * "adi,ad7606-8" > + * "adi,ad7606-6" > + * "adi,ad7606-4" > +- reg: SPI chip select number for the device > +- spi-max-frequency: Max SPI frequency to use > + see: Documentation/devicetree/bindings/spi/spi-bus.txt > +- spi-cpha: See Documentation/devicetree/bindings/spi/spi-bus.txt > +- avcc-supply: phandle to the Avcc power supply > +- interrupts: IRQ line for the ADC > + see: Documentation/devicetree/bindings/interrupt-controller/interrupts.= txt > +- adi,conversion-start-gpios: must be the device tree identifier of the = CONVST pin. > + This logic input is used to initiate conversions on the analog > + input channels. > + > +Optional properties: > + > +- reset-gpios: must be the device tree identifier of the RESET pin. If s= pecified, > + it will be asserted during driver probe. > +- standby-gpios: must be the device tree identifier of the STBY pin. Thi= s pin is used > + to place the AD7606 into one of two power-down modes, Standby mode or > + Shutdown mode. > +- adi,first-data-gpios: must be the device tree identifier of the FRSTDA= TA pin. > + The FRSTDATA output indicates when the first channel, V1, is > + being read back on either the parallel, byte or serial interface. > +- adi,range-gpios: must be the device tree identifier of the RANGE pin. = The polarity on > + this pin determines the input range of the analog input channels.= If > + this pin is tied to a logic high, the analog input range is =C2= =B110V for > + all channels. If this pin is tied to a logic low, the analog inpu= t range > + is =C2=B15V for all channels. > + > +Example: > + > + adc@0 { > + compatible =3D "adi,ad7606-8"; > + reg =3D <0>; > + spi-max-frequency =3D <1000000>; > + spi-cpol; > + > + avcc-supply =3D <&adc_vref>; > + > + interrupts =3D <25 IRQ_TYPE_EDGE_FALLING>; > + interrupt-parent =3D <&gpio>; > + > + adi,conversion-start-gpios =3D <&gpio 17 0>; > + reset-gpios =3D <&gpio 27 0>; > + adi,first-data-gpios =3D <&gpio 22 0>; > + standby-gpios =3D <&gpio 24 0>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 843545d..6d63db4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -845,6 +845,7 @@ L: linux-iio@vger.kernel.org > W: http://ez.analog.com/community/linux-device-drivers > S: Supported > F: drivers/iio/adc/ad7606.c > +F: Documentation/devicetree/bindings/iio/adc/ad7606.txt > =20 > ANALOG DEVICES INC AD9389B DRIVER > M: Hans Verkuil <hans.verkuil@cisco.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Stefan Popa <stefan.popa@analog.com> Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <knaack.h@gmx.de>, <lars@metafoo.de>, <pmeerw@pmeerw.net>, <Michael.Hennerich@analog.com>, <gregkh@linuxfoundation.org>, <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 2/2] dt-bindings: iio: adc: Add docs for AD7606 ADC Date: Sat, 1 Dec 2018 17:00:46 +0000 [thread overview] Message-ID: <20181201170046.13eef1fc@archlinux> (raw) Message-ID: <20181201170046.rrwTw_u2CW6bjlu7VfcIs99hWWb628IgSMP1QzBBlIY@z> (raw) In-Reply-To: <1543510663-14921-1-git-send-email-stefan.popa@analog.com> On Thu, 29 Nov 2018 18:57:43 +0200 Stefan Popa <stefan.popa@analog.com> wrote: > Document support for AD7606 Analog to Digital Converter. > > Signed-off-by: Stefan Popa <stefan.popa@analog.com> Looks good to me, but as it's a non trivial binding in complexity I'd definitely like a DT maintainers input before applying this. Thanks, Jonathan > --- > Changes in v2: > - fixed indentation issues. > - used gpios instead of gpio. > - added vendor prefix for conversion-start-gpios, first-data-gpios, > and range-gpios. > Changes in v3: > - Added adi,oversampling-ratio-gpios. > > .../devicetree/bindings/iio/adc/adi,ad7606.txt | 54 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt > new file mode 100644 > index 0000000..02fae23 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt > @@ -0,0 +1,54 @@ > +Analog Devices AD7606 Simultaneous Sampling ADC > + > +Required properties for the AD7606: > + > +- compatible: Must be one of > + * "adi,ad7605-4" > + * "adi,ad7606-8" > + * "adi,ad7606-6" > + * "adi,ad7606-4" > +- reg: SPI chip select number for the device > +- spi-max-frequency: Max SPI frequency to use > + see: Documentation/devicetree/bindings/spi/spi-bus.txt > +- spi-cpha: See Documentation/devicetree/bindings/spi/spi-bus.txt > +- avcc-supply: phandle to the Avcc power supply > +- interrupts: IRQ line for the ADC > + see: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > +- adi,conversion-start-gpios: must be the device tree identifier of the CONVST pin. > + This logic input is used to initiate conversions on the analog > + input channels. > + > +Optional properties: > + > +- reset-gpios: must be the device tree identifier of the RESET pin. If specified, > + it will be asserted during driver probe. > +- standby-gpios: must be the device tree identifier of the STBY pin. This pin is used > + to place the AD7606 into one of two power-down modes, Standby mode or > + Shutdown mode. > +- adi,first-data-gpios: must be the device tree identifier of the FRSTDATA pin. > + The FRSTDATA output indicates when the first channel, V1, is > + being read back on either the parallel, byte or serial interface. > +- adi,range-gpios: must be the device tree identifier of the RANGE pin. The polarity on > + this pin determines the input range of the analog input channels. If > + this pin is tied to a logic high, the analog input range is ±10V for > + all channels. If this pin is tied to a logic low, the analog input range > + is ±5V for all channels. > + > +Example: > + > + adc@0 { > + compatible = "adi,ad7606-8"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + spi-cpol; > + > + avcc-supply = <&adc_vref>; > + > + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; > + interrupt-parent = <&gpio>; > + > + adi,conversion-start-gpios = <&gpio 17 0>; > + reset-gpios = <&gpio 27 0>; > + adi,first-data-gpios = <&gpio 22 0>; > + standby-gpios = <&gpio 24 0>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 843545d..6d63db4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -845,6 +845,7 @@ L: linux-iio@vger.kernel.org > W: http://ez.analog.com/community/linux-device-drivers > S: Supported > F: drivers/iio/adc/ad7606.c > +F: Documentation/devicetree/bindings/iio/adc/ad7606.txt > > ANALOG DEVICES INC AD9389B DRIVER > M: Hans Verkuil <hans.verkuil@cisco.com>
next prev parent reply other threads:[~2018-12-02 4:13 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-29 16:57 [PATCH v3 2/2] dt-bindings: iio: adc: Add docs for AD7606 ADC Stefan Popa 2018-12-01 17:00 ` Jonathan Cameron [this message] 2018-12-01 17:00 ` Jonathan Cameron 2018-12-07 23:47 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181201170046.13eef1fc@archlinux \ --to=jic23@kernel.org \ --cc=Michael.Hennerich@analog.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pmeerw@pmeerw.net \ --cc=robh+dt@kernel.org \ --cc=stefan.popa@analog.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).