* [PATCH] iio: accel: kxcjk1013: Improve comments on KIOX010A and KIOX020A ACPI ids
@ 2019-08-18 11:23 Hans de Goede
2019-08-18 17:51 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2019-08-18 11:23 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Hans de Goede, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, linux-iio
The KIOX010A and KIOX020A ACPI ids go hand in hand, they are used in
yoga style 2-in-1s, with KIOX010A indicating the KXCJ91008 sensor in the
display of the 2-in-1 and KIOX020A indicating the KXCJ91008 sensor in the
base.
Improve the existing comment on the "KIOX010A" kx_acpi_match table entry
to make clear we are talking about a yoga-style (360 degree hinges) device
here and add a similar comment to the "KIOX020A" entry.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/iio/accel/kxcjk-1013.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
index 6645771aa349..fee535d6e45b 100644
--- a/drivers/iio/accel/kxcjk-1013.c
+++ b/drivers/iio/accel/kxcjk-1013.c
@@ -1486,8 +1486,8 @@ static const struct acpi_device_id kx_acpi_match[] = {
{"KIOX0008", KXCJ91008},
{"KIOX0009", KXTJ21009},
{"KIOX000A", KXCJ91008},
- {"KIOX010A", KXCJ91008}, /* KXCJ91008 inside the display of a 2-in-1 */
- {"KIOX020A", KXCJ91008},
+ {"KIOX010A", KXCJ91008}, /* KXCJ91008 in the display of a yoga 2-in-1 */
+ {"KIOX020A", KXCJ91008}, /* KXCJ91008 in the base of a yoga 2-in-1 */
{"KXTJ1009", KXTJ21009},
{"KXJ2109", KXTJ21009},
{"SMO8500", KXCJ91008},
--
2.23.0.rc2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: accel: kxcjk1013: Improve comments on KIOX010A and KIOX020A ACPI ids
2019-08-18 11:23 [PATCH] iio: accel: kxcjk1013: Improve comments on KIOX010A and KIOX020A ACPI ids Hans de Goede
@ 2019-08-18 17:51 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-08-18 17:51 UTC (permalink / raw)
To: Hans de Goede
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler, linux-iio
On Sun, 18 Aug 2019 13:23:06 +0200
Hans de Goede <hdegoede@redhat.com> wrote:
> The KIOX010A and KIOX020A ACPI ids go hand in hand, they are used in
> yoga style 2-in-1s, with KIOX010A indicating the KXCJ91008 sensor in the
> display of the 2-in-1 and KIOX020A indicating the KXCJ91008 sensor in the
> base.
>
> Improve the existing comment on the "KIOX010A" kx_acpi_match table entry
> to make clear we are talking about a yoga-style (360 degree hinges) device
> here and add a similar comment to the "KIOX020A" entry.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied to the togreg branch of iio.git and pushed out as testing to be
ignored by the autobuilders.
Thanks,
Jonathan
> ---
> drivers/iio/accel/kxcjk-1013.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index 6645771aa349..fee535d6e45b 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -1486,8 +1486,8 @@ static const struct acpi_device_id kx_acpi_match[] = {
> {"KIOX0008", KXCJ91008},
> {"KIOX0009", KXTJ21009},
> {"KIOX000A", KXCJ91008},
> - {"KIOX010A", KXCJ91008}, /* KXCJ91008 inside the display of a 2-in-1 */
> - {"KIOX020A", KXCJ91008},
> + {"KIOX010A", KXCJ91008}, /* KXCJ91008 in the display of a yoga 2-in-1 */
> + {"KIOX020A", KXCJ91008}, /* KXCJ91008 in the base of a yoga 2-in-1 */
> {"KXTJ1009", KXTJ21009},
> {"KXJ2109", KXTJ21009},
> {"SMO8500", KXCJ91008},
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-18 17:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-18 11:23 [PATCH] iio: accel: kxcjk1013: Improve comments on KIOX010A and KIOX020A ACPI ids Hans de Goede
2019-08-18 17:51 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).