From: Jonathan Cameron <jic23@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 1/7] iio: adc: max1027: Add debugfs register read support
Date: Sat, 12 Oct 2019 14:56:21 +0100 [thread overview]
Message-ID: <20191012145621.228d4efc@archlinux> (raw)
In-Reply-To: <20191007120001.61c8ef71@xps13>
On Mon, 7 Oct 2019 12:00:01 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Hi Jonathan,
>
> Jonathan Cameron <jic23@kernel.org> wrote on Sun, 6 Oct 2019 11:04:24
> +0100:
>
> > On Thu, 3 Oct 2019 19:33:55 +0200
> > Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > > Until now, only write operations were supported. Force two bytes read
> > > operation when reading from this register (might be wrong when reading
> > > the temperature, but will work with any other value).
> >
> > That's worrying as comments go. Just return an error on the temperature
> > register if it's going to do the wrong thing.
>
> Actually the debugfs_reg_access hook is supposedly stateless. When
> reading registers I don't know what I am reading because the "source" is
> selected during the write operation, so I have no reliable way to know
> what I am reading.
>
> I set the read length to 2 bytes because most of the "atomic"reads are
> two bytes and it allows us to test various commands directly from
> userspace and read meaningful values. This is a limitation as:
> * Voltage 'atomic' reads are 2 bytes
> * Temperature 'atomic' reads are 2 bytes but never come alone (usually
> one voltage input of 2B will follow).
> * Any other 'condensed' input will be more than 2 bytes, ie. several
> voltage values in one go.
>
> In any case, doing a software reset of the chip will turn it back
> into a working state no matter what was requested/read.
>
> For me, 2-byte reads is a "good enough" solution that will work with
> almost all the simplest ('atomic') SPI operations, but if you think
> limiting to 2-bytes access is a problem (right now there is only write
> access, which is kind of useless on its own) then let's drop the patch.
> But I wanted to contribute it because it really helped me during the
> development.
This is fine as is. Comment was worrying so could perhaps have given
more detail. Still it's a debug interface, people get to look at the
datasheet if they are using this :)
Jonathan
>
>
> Thanks,
> Miquèl
next prev parent reply other threads:[~2019-10-12 13:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 17:33 [PATCH v2 0/7] Introduce max12xx ADC support Miquel Raynal
2019-10-03 17:33 ` [PATCH v2 1/7] iio: adc: max1027: Add debugfs register read support Miquel Raynal
2019-10-06 10:04 ` Jonathan Cameron
2019-10-07 10:00 ` Miquel Raynal
2019-10-12 13:56 ` Jonathan Cameron [this message]
2019-10-03 17:33 ` [PATCH v2 2/7] iio: adc: max1027: Make it optional to use interrupts Miquel Raynal
2019-10-06 10:18 ` Jonathan Cameron
2019-10-07 10:01 ` Miquel Raynal
2019-10-07 11:44 ` Jonathan Cameron
2019-10-03 17:33 ` [PATCH v2 3/7] iio: adc: max1027: Reset the device at probe time Miquel Raynal
2019-10-03 17:33 ` [PATCH v2 4/7] iio: adc: max1027: Prepare the introduction of different resolutions Miquel Raynal
2019-10-06 10:22 ` Jonathan Cameron
2019-10-07 10:03 ` Miquel Raynal
2019-10-03 17:33 ` [PATCH v2 5/7] iio: adc: max1027: Introduce 12-bit devices support Miquel Raynal
2019-10-06 10:24 ` Jonathan Cameron
2019-10-03 17:34 ` [PATCH v2 6/7] dt-bindings: iio: adc: max1027: Mark interrupts as optional Miquel Raynal
2019-10-03 17:34 ` [PATCH v2 7/7] dt-bindings: iio: adc: max1027: Document max12xx series compatibles Miquel Raynal
2019-10-06 10:27 ` Jonathan Cameron
2019-10-07 10:04 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191012145621.228d4efc@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).