From: Stefano Brivio <sbrivio@redhat.com>
To: Deepak R Varma <mh12gx2825@gmail.com>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
daniel.baluta@gmail.com, kieran.bingham@ideasonboard.com,
lars@metafoo.de, Michael.Hennerich@analog.com,
stefan.popa@analog.com, jic23@kernel.org, knaack.h@gmx.de,
pmeerw@pmeerw.net, linux-iio@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH 1/2] staging: iio: adc: ad7192: Reformat lines crossing 80 columns
Date: Wed, 18 Mar 2020 09:31:58 +0100 [thread overview]
Message-ID: <20200318093158.192a27ce@elisabeth> (raw)
In-Reply-To: <50419988d636c90511a07da256c91aa3b3e33bff.1584505215.git.mh12gx2825@gmail.com>
On Wed, 18 Mar 2020 09:56:59 +0530
Deepak R Varma <mh12gx2825@gmail.com> wrote:
> Macro arguments are computed at the time of macro invocation. This makes
> the lines cross 80 column width. Add variables to perform the
> calculations before hand and use these new variable in the macro calls
> instead.
>
> Also re-indent enum members to address checkpatch warning / check messages.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
> drivers/staging/iio/adc/ad7192.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index bf3e2a9cc07f..0265f6607d75 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -156,8 +156,8 @@
> */
>
> enum {
> - AD7192_SYSCALIB_ZERO_SCALE,
> - AD7192_SYSCALIB_FULL_SCALE,
> + AD7192_SYSCALIB_ZERO_SCALE,
> + AD7192_SYSCALIB_FULL_SCALE,
> };
>
> struct ad7192_state {
> @@ -477,17 +477,18 @@ static ssize_t ad7192_set(struct device *dev,
> }
>
> static void ad7192_get_available_filter_freq(struct ad7192_state *st,
> - int *freq)
> + int *freq)
> {
> unsigned int fadc;
> + unsigned int sync3_filter, sync4_filter;
>
> /* Formulas for filter at page 25 of the datasheet */
> - fadc = DIV_ROUND_CLOSEST(st->fclk,
> - AD7192_SYNC4_FILTER * AD7192_MODE_RATE(st->mode));
> + sync4_filter = AD7192_SYNC4_FILTER * AD7192_MODE_RATE(st->mode);
Have you read page 25 of the datasheet? Why is this called
sync4_filter, with a 'y'?
--
Stefano
next prev parent reply other threads:[~2020-03-18 8:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 4:26 [PATCH 0/2] staging: iio: adc: General code reformatting / cleanup patchset Deepak R Varma
2020-03-18 4:26 ` [PATCH 1/2] staging: iio: adc: ad7192: Reformat lines crossing 80 columns Deepak R Varma
2020-03-18 6:00 ` Greg KH
2020-03-18 15:12 ` DEEPAK VARMA
2020-03-18 15:18 ` Greg KH
2020-03-18 8:31 ` Stefano Brivio [this message]
2020-03-18 16:06 ` [Outreachy kernel] " DEEPAK VARMA
2020-03-18 16:22 ` Rohit Sarkar
2020-03-18 16:43 ` DEEPAK VARMA
2020-03-18 16:44 ` Lars-Peter Clausen
2020-03-18 17:31 ` DEEPAK VARMA
2020-03-19 7:04 ` Ardelean, Alexandru
2020-03-18 4:28 ` [PATCH 2/2] staging: iio: adc: ad7280a: Add spaces around operators Deepak R Varma
2020-03-18 6:00 ` Greg KH
2020-03-18 15:09 ` DEEPAK VARMA
2020-03-18 15:12 ` Lars-Peter Clausen
2020-03-18 15:19 ` Greg KH
2020-03-18 16:23 ` DEEPAK VARMA
2020-03-18 16:27 ` Greg KH
2020-03-18 16:28 ` [Outreachy kernel] " Julia Lawall
2020-03-18 17:00 ` DEEPAK VARMA
2020-03-19 7:00 ` Ardelean, Alexandru
2020-03-19 7:03 ` Julia Lawall
2020-03-19 7:07 ` Ardelean, Alexandru
2020-03-19 16:16 ` DEEPAK VARMA
2020-03-20 7:13 ` Ardelean, Alexandru
2020-03-21 10:25 ` DEEPAK VARMA
2020-03-22 9:06 ` Ardelean, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318093158.192a27ce@elisabeth \
--to=sbrivio@redhat.com \
--cc=Michael.Hennerich@analog.com \
--cc=daniel.baluta@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mh12gx2825@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).