From: Greg KH <gregkh@linuxfoundation.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Deepak R Varma <mh12gx2825@gmail.com>,
outreachy-kernel@googlegroups.com, daniel.baluta@gmail.com,
kieran.bingham@ideasonboard.com, Michael.Hennerich@analog.com,
stefan.popa@analog.com, jic23@kernel.org, knaack.h@gmx.de,
pmeerw@pmeerw.net, linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: iio: adc: ad7280a: Add spaces around operators
Date: Wed, 18 Mar 2020 16:19:24 +0100 [thread overview]
Message-ID: <20200318151924.GB2862853@kroah.com> (raw)
In-Reply-To: <35afdc4b-bd59-7851-aa4f-3d8807668931@metafoo.de>
On Wed, Mar 18, 2020 at 04:12:28PM +0100, Lars-Peter Clausen wrote:
> On 3/18/20 7:00 AM, Greg KH wrote:
> > On Wed, Mar 18, 2020 at 09:58:13AM +0530, Deepak R Varma wrote:
> > > Add spaces around operator symbols to improve readability. Warning
> > > flagged by checkpatch script.
> > >
> > > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> > > ---
> > > drivers/staging/iio/adc/ad7280a.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> > > index 19a5f244dcae..34ca0d09db85 100644
> > > --- a/drivers/staging/iio/adc/ad7280a.c
> > > +++ b/drivers/staging/iio/adc/ad7280a.c
> > > @@ -825,14 +825,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
> > > }
> > > static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> > > - in_voltage-voltage_thresh_low_value,
> > > + in_voltage - voltage_thresh_low_value,
> > > 0644,
> > > ad7280_read_channel_config,
> > > ad7280_write_channel_config,
> > > AD7280A_CELL_UNDERVOLTAGE);
> > > static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
> > > - in_voltage-voltage_thresh_high_value,
> > > + in_voltage - voltage_thresh_high_value,
> > > 0644,
> > > ad7280_read_channel_config,
> > > ad7280_write_channel_config,
> >
> > Did you try building this code?
> >
> > It catches everyone...
>
> The problem is it builds. The token is stringyfied and
> "in_voltage - voltage_thresh_high_value" is a valid string.
Ah, I thought it used to break the build when it happened. Oh well,
it's still a great "trick" to see if people understand C or not :)
thanks,
greg k-h
next prev parent reply other threads:[~2020-03-18 15:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 4:26 [PATCH 0/2] staging: iio: adc: General code reformatting / cleanup patchset Deepak R Varma
2020-03-18 4:26 ` [PATCH 1/2] staging: iio: adc: ad7192: Reformat lines crossing 80 columns Deepak R Varma
2020-03-18 6:00 ` Greg KH
2020-03-18 15:12 ` DEEPAK VARMA
2020-03-18 15:18 ` Greg KH
2020-03-18 8:31 ` [Outreachy kernel] " Stefano Brivio
2020-03-18 16:06 ` DEEPAK VARMA
2020-03-18 16:22 ` Rohit Sarkar
2020-03-18 16:43 ` DEEPAK VARMA
2020-03-18 16:44 ` Lars-Peter Clausen
2020-03-18 17:31 ` DEEPAK VARMA
2020-03-19 7:04 ` Ardelean, Alexandru
2020-03-18 4:28 ` [PATCH 2/2] staging: iio: adc: ad7280a: Add spaces around operators Deepak R Varma
2020-03-18 6:00 ` Greg KH
2020-03-18 15:09 ` DEEPAK VARMA
2020-03-18 15:12 ` Lars-Peter Clausen
2020-03-18 15:19 ` Greg KH [this message]
2020-03-18 16:23 ` DEEPAK VARMA
2020-03-18 16:27 ` Greg KH
2020-03-18 16:28 ` [Outreachy kernel] " Julia Lawall
2020-03-18 17:00 ` DEEPAK VARMA
2020-03-19 7:00 ` Ardelean, Alexandru
2020-03-19 7:03 ` Julia Lawall
2020-03-19 7:07 ` Ardelean, Alexandru
2020-03-19 16:16 ` DEEPAK VARMA
2020-03-20 7:13 ` Ardelean, Alexandru
2020-03-21 10:25 ` DEEPAK VARMA
2020-03-22 9:06 ` Ardelean, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318151924.GB2862853@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Michael.Hennerich@analog.com \
--cc=daniel.baluta@gmail.com \
--cc=jic23@kernel.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mh12gx2825@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).