Re: [RFC PATCH 0/2] iio: st-accel: Add support for Silan clones

[Jonathan Cameron <Jonathan.Cameron@Huawei.com>]

On Tue, 11 Aug 2020 22:48:44 +0900
Daniel Palmer <daniel@0x0f.com> wrote:

> This small series adds support for the Silan SC7A20 and SC7A30E
> accelerometers that seem to be clones or at least based on the
> LIS2DH from ST.
> 
> These chips seem to be widely used in car dash recorders and the
> midrived08 dash recorder that I'm trying to mainline support for
> has a SC7A20.
> 
> This is RFC because I'm not sure if adding clone chips into this
> driver is going to cause anyone trouble and I'm thinking there has
> to be a better way of supporting both of the chips that are basically
> the same but have different WAI register values than copy/pasting the
> block and changing the WAI value.

The different WAI value suggests to me that we might be looking at
something made under license, or manufactured for them by ST.

Anyhow, it's not unusual to have cloned parts supported by a common
kernel driver so that shouldn't be a problem.

Only thing to note is we can't necessarily expect Denis to be able
to review any changes to the driver that might affect these parts.

If Denis is willing, we could add an entry to MAINTAINERS for these
and add you as a reviewer so that you should get any future patches
sent to you as well.

Denis, what's your view on this, or can you shed any light on
these parts?


> 
> Daniel Palmer (2):
>   dt-bindings: vendor-prefixes: Add vendor prefix for Silan
>   iio: st-accel: Add support for Silan SC7A20 and SC7A30E
> 
>  .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
>  drivers/iio/accel/st_accel.h                  |   4 +
>  drivers/iio/accel/st_accel_core.c             | 159 +++++++++++++++++-
>  drivers/iio/accel/st_accel_i2c.c              |  10 ++
>  4 files changed, 174 insertions(+), 1 deletion(-)
>